After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701269 - osdWindow: Make sure the OSD is always our topmost chrome element
osdWindow: Make sure the OSD is always our topmost chrome element
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-30 12:36 UTC by Rui Matos
Modified: 2013-06-05 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
osdWindow: Make sure the OSD is always our topmost chrome element (856 bytes, patch)
2013-05-30 12:36 UTC, Rui Matos 		reviewed Details | Review
osdWindow: Make sure the OSD is always our topmost chrome element (899 bytes, patch)
2013-06-05 13:14 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-05-30 12:36:32 UTC 
Going forward we should perhaps introduce a set of layers with an API
to add/move/remove actors so that we can be sure that things are
always properly stacked without these ad-hoc bandages.

In this specific case though, I think this is correct and could go in
3.8.
Comment 1 Rui Matos 2013-05-30 12:36:34 UTC 
Created attachment 245643 [details] [review]
osdWindow: Make sure the OSD is always our topmost chrome element

In particular this fixes the OSD showing up behind a modal dialog's
lightbox.
Comment 2 Florian Müllner 2013-06-05 13:07:31 UTC 
Review of attachment 245643 [details] [review]:

::: js/ui/osdWindow.js
@@ +139,3 @@
             this.actor.show();
             this.actor.opacity = 0;
+            this.actor.raise_top();

raise_top() is deprecated, so that should probably be
  this.actor.get_parent().set_child_above_sibling(this.actor, null);
Comment 3 Rui Matos 2013-06-05 13:14:20 UTC 
Created attachment 246071 [details] [review]
osdWindow: Make sure the OSD is always our topmost chrome element

In particular this fixes the OSD showing up behind a modal dialog's
lightbox.
Comment 4 Florian Müllner 2013-06-05 13:27:17 UTC 
Review of attachment 246071 [details] [review]:

LG
Comment 5 Rui Matos 2013-06-05 13:37:20 UTC 
Attachment 246071 [details] pushed as 494fcfe - osdWindow: Make sure the OSD is always our topmost chrome element