After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701191 - rtsp-media: UTC ranges difficult to handle in element seeks
rtsp-media: UTC ranges difficult to handle in element seeks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-29 11:49 UTC by David Svensson Fors
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media: possibility to override range time conversion (3.42 KB, patch)
2013-05-29 11:49 UTC, David Svensson Fors
committed Details | Review

Description David Svensson Fors 2013-05-29 11:49:29 UTC
Created attachment 245546 [details] [review]
media: possibility to override range time conversion

In gst_rtsp_media_seek, gst_rtsp_range_get_times is used for converting a GstRTSPTimeRange to GstClockTimes before seeking on the media pipeline.

We have experienced problems with this for UTC ranges. For such ranges, gst_rtsp_range_get_times gives GstClockTimes that are nanoseconds since 1900. Such times are not meaningful in the element in the pipeline that handles our seeks. It is not clear to us how the seek function in the element could distinguish between such times and the times for other types of ranges, such as NPT. NPT ranges result in seeks between "normal" times such as 0:00:02.000000000 and 0:00:04.000000000.

Our suggestion, in the attached patch, is to make it possible to override a method in GstRTSPMedia where the GstRTSPTimeRange is converted to GstClockTimes. In our GstRTSPMedia subclass, we would use knowledge about UTC times of the start and end of the media for computing useful GstClockTimes.
Comment 1 Wim Taymans 2013-06-03 12:29:46 UTC
commit 7efa871c1f99b4a4e47a0d216bd76a09da89b731
Author: David Svensson Fors <davidsf@axis.com>
Date:   Wed May 29 13:45:00 2013 +0200

    media: possibility to override range time conversion
    
    Make it possible to override the conversion from GstRTSPTimeRange to
    GstClockTimes, that is done before seeking on the media
    pipeline. Overriding can be useful for UTC ranges, where the default
    conversion gives nanoseconds since 1900.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=701191