After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701174 - Update misleading filechooser documentation
Update misleading filechooser documentation
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
filechooser-commit-now
Depends on:
Blocks:
 
 
Reported: 2013-05-29 07:27 UTC by Timothy Arceri
Modified: 2013-06-20 17:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix misleading documentation (881 bytes, patch)
2013-05-29 07:33 UTC, Timothy Arceri 		accepted-commit_now Details | Review

Description Timothy Arceri 2013-05-29 07:27:24 UTC 
The filechooser widget is created on the application side and I have been told that there is no default preview widget created by GTK. However the documentation for gtk_file_chooser_set_preview_widget() says that if a widget is not provided that GTK may generate one internally.
Comment 1 Timothy Arceri 2013-05-29 07:33:37 UTC 
Created attachment 245523 [details] [review]
Fix misleading documentation

This patch updates the documentation to reflect what actually happens. If I'm wrong about this feel free to correct me.
Comment 2 Matthias Clasen 2013-05-31 02:02:47 UTC 
Review of attachment 245523 [details] [review]:

That comment was probably added in the expectation that we might add an internal preview at some point. Obviously, that never happened, so lets just remove it.
Comment 3 Timothy Arceri 2013-06-03 22:05:50 UTC 
Can some please commit this for me. Thanks.
Comment 4 Federico Mena Quintero 2013-06-20 17:40:46 UTC 
Pushed to master as 555e0a7.  Thanks for catching this.