After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701167 - overviewControls: Don't push window thumbs over when workspaces are invisible
overviewControls: Don't push window thumbs over when workspaces are invisible
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 702531 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-29 01:21 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-10-16 04:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overviewControls: Don't push window thumbs over when workspaces are invisible (1.29 KB, patch)
2013-05-29 01:21 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
overviewControls: Don't push window thumbs over when workspaces are invisible (1.21 KB, patch)
2013-05-29 17:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-05-29 01:21:16 UTC 
When the workspace thumbnails are invisible, pretend that the sliding control
is completely slid out.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-05-29 01:21:19 UTC 
Created attachment 245508 [details] [review]
overviewControls: Don't push window thumbs over when workspaces are invisible
Comment 2 Florian Müllner 2013-05-29 16:52:30 UTC 
Review of attachment 245508 [details] [review]:

::: js/ui/overviewControls.js
@@ +247,3 @@
         Main.layoutManager.connect('monitors-changed', Lang.bind(this, this.updateSlide));
         this.actor.connect('notify::hover', Lang.bind(this, this.updateSlide));
+        this._thumbnailsBox.actor.connect('notify::visible', Lang.bind(this, this.updateSlide));

Alternatively you could use g_object_bind_property to bind actor:visible to thumbnailsBox.actor:visible
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-05-29 17:05:07 UTC 
Created attachment 245569 [details] [review]
overviewControls: Don't push window thumbs over when workspaces are invisible

Make the sliding control invisible when the thumbnails box is as well.
Comment 4 Florian Müllner 2013-05-29 17:08:50 UTC 
Review of attachment 245569 [details] [review]:

Yup
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-05-29 17:18:43 UTC 
Attachment 245569 [details] pushed as 5a2269c - overviewControls: Don't push window thumbs over when workspaces are invisible
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-06-18 19:35:08 UTC 
*** Bug 702531 has been marked as a duplicate of this bug. ***
Comment 7 Ahmad Samir 2013-10-16 04:41:25 UTC 
Hello, could this fix get backported to the 3.8 branch? (I still see this issue with gnome-shell-3.8.4).