After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701117 - rtsp-address-pool: Add API to allow allocation outside of the address range
rtsp-address-pool: Add API to allow allocation outside of the address range
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-28 07:23 UTC by Ognyan Tonchev (redstar_)
Modified: 2013-09-24 21:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add API to allow allocation outside of the address range (4.06 KB, patch)
2013-05-28 07:24 UTC, Ognyan Tonchev (redstar_) 		none Details | Review
Add API to allow allocation outside of the address range (7.81 KB, patch)
2013-06-10 14:56 UTC, Ognyan Tonchev (redstar_) 		none Details | Review

Description Ognyan Tonchev (redstar_) 2013-05-28 07:23:08 UTC 
This is a sligthly modified version of ocrete's patch - http://cgit.collabora.com/git/user/tester/gst-rtsp-server.git/commit/?h=allow-any-port&id=a5549e4c1f7a342088ffa42ed21cff1aeaf01325

The original patch allows allocation of any port while the address still has to be in the address pool. This modified version allows just any address and port to be reserved in the pool, thus clients will be allowed to choose their own transport settings regardless of what is in the pool.
Comment 1 Ognyan Tonchev (redstar_) 2013-05-28 07:24:02 UTC 
Created attachment 245429 [details] [review]
Add API to allow allocation outside of the address range
Comment 2 Olivier Crête 2013-06-03 17:48:51 UTC 
Looks ok to me, Wim ?
Comment 3 Ognyan Tonchev (redstar_) 2013-06-10 14:56:19 UTC 
Created attachment 246409 [details] [review]
Add API to allow allocation outside of the address range

Reserved addresses will be stored in the pool and thus it won't be possible to reserve the same address twice.
Comment 4 Ognyan Tonchev (redstar_) 2013-06-10 15:22:29 UTC 
Patch updated after discussing it with Wim on irc.
Comment 5 Wim Taymans 2013-07-01 14:55:57 UTC 
you will need to list your requirements again before I merge any of this. 

What is the point of using the pool if you allow anything? I thought the address pool was to restrict addresses and keep track of what is in use?

If you're going to allow anything, why not add all possible addresses to the pool?
Comment 6 Ognyan Tonchev (redstar_) 2013-09-24 20:51:26 UTC 
This is not a requirement for us anymore. The bug can be closed.