After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701072 - crash when nmapping rtsp-server
crash when nmapping rtsp-server
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
1.x
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-27 08:28 UTC by Alexander Schrab
Modified: 2014-02-25 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.83 KB, patch)
2013-05-27 11:02 UTC, Alexander Schrab 		committed Details | Review

Description Alexander Schrab 2013-05-27 08:28:28 UTC 
The rtsp server fails when nmapping the host. The reason is that gst_rtsp_client_accept returns FALSE without setting *error to anything and default_accept_client then dereferences *error to type the error message, resulting in crashes.

Working on a patch...
Comment 1 Alexander Schrab 2013-05-27 11:02:48 UTC 
Created attachment 245376 [details] [review]
Patch

Turns out there are two problems:

1. the mentioned error problem
2. when accept returns false, we return false from the io function. I beliave this is wrong. There is no reason to stop accepting incoming connections because an earlier client caused error.
Comment 2 Sebastian Dröge (slomo) 2013-05-27 11:21:45 UTC 
commit c75e1c6b4741cfe9f3ad4264271ce472f66de7c2
Author: Alexander Schrab <alexas@axis.com>
Date:   Mon May 27 12:58:07 2013 +0200

    rtsp-server: Do not crash on nmapping of server
    
    * generate error when gst_rtsp_connection_accept fails
    * do not stop accepting incoming connections because
      accepting a client fails
    
    https://bugzilla.gnome.org/show_bug.cgi?id=701072