After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700839 - lock screen totally broken after "Log in as a different user"
lock screen totally broken after "Log in as a different user"
Status: RESOLVED DUPLICATE of bug 700901
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 701516 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-22 13:49 UTC by Tomeu Vizoso
Modified: 2013-06-04 06:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stop animations in the screen shield when logging in (915 bytes, patch)
2013-05-22 15:44 UTC, Tomeu Vizoso
rejected Details | Review

Description Tomeu Vizoso 2013-05-22 13:49:24 UTC
Steps:

1. Log in from GDM
2. Click on the Lock menu item in the user menu
3. Click on the "Log in as a different user" link/button
4. Log with the same user as in 1
5. Click on the Lock menu item in the user menu

What should happen:

You get the lock screen shield, and the unlock dialog beneath it, functional.

What happens right now:

You get an empty gray screen instead of the unlock dialog.
Comment 1 Florian Müllner 2013-05-22 13:52:39 UTC
Mmh, I can't reproduce that ...
Comment 2 Tomeu Vizoso 2013-05-22 15:42:47 UTC
(In reply to comment #1)
> Mmh, I can't reproduce that ...

This seems to happen because of clock synchronization, so it can only be reproduced on setups that have that working. Could it be the case?

What seems to happen is that when "Log in as a different user" is clicked, an animation is started to show the screen shield, but as a new X server is immediately started, that animation is "on hold" because of sync on vblank.

Once the user logs again, GDM returns to the first X server, so the animation can complete on the next frame. But before it does, the screen shield is removed.

What happens is that the screen shield is effectively removed, but _lockScreenState is SHOWN. This inconsistency causes future calls to _resetLockScreen to bail out early, which renders the lock screen useless.
Comment 3 Tomeu Vizoso 2013-05-22 15:44:30 UTC
Created attachment 245050 [details] [review]
Stop animations in the screen shield when logging in

Otherwise there could be a race when the animation to show the
shield is still running when the user authenticates successfully.
Comment 4 Ray Strode [halfline] 2013-06-03 19:33:11 UTC
*** Bug 701516 has been marked as a duplicate of this bug. ***
Comment 5 Ray Strode [halfline] 2013-06-03 20:19:38 UTC
Review of attachment 245050 [details] [review]:

Thanks for looking into this.  It looks like there's a somewhat nicer approach on a different bug so i'm going to mark this one rejected.
Comment 6 Ray Strode [halfline] 2013-06-03 20:20:02 UTC

*** This bug has been marked as a duplicate of bug 700901 ***
Comment 7 Tomeu Vizoso 2013-06-04 06:29:17 UTC
(In reply to comment #5)
> Review of attachment 245050 [details] [review]:
> 
> Thanks for looking into this.  It looks like there's a somewhat nicer approach
> on a different bug so i'm going to mark this one rejected.

Don't see that much difference between this and https://bug700901.bugzilla-attachments.gnome.org/attachment.cgi?id=245967 , but ok.