GNOME Bugzilla – Bug 700784
Disable all extensions in reverse order
Last modified: 2013-05-23 08:02:23 UTC
So we avoid having to disable and enable an extension that is to be disabled later anyway.
Created attachment 244959 [details] [review] Disable all extensions in reverse order
Review of attachment 244959 [details] [review]: This is still wrong. enabledExtensions is in the order that they are in the key, which is irrelevant. So the old code is clearly wrong. But extensionOrder is the order that they were enabled in, with the first item being enabled earliest. So if the order is A, B, C, then we need to disable them as C, B, A. So the order needs to be extensionOrder, but reversed.
Created attachment 244972 [details] [review] Disable all extensions in reverse order So we avoid having to disable and enable an extension that is to be disabled later anyway.
Created attachment 244973 [details] [review] Disable all extensions in reverse order So we avoid having to disable and enable an extension that is to be disabled later anyway.
Review of attachment 244972 [details] [review]: Uh, this is the same patch?
Review of attachment 244973 [details] [review]: OK.
Comment on attachment 244973 [details] [review] Disable all extensions in reverse order commit deb1adb780570dab3f48b6856b1a6bfb274bdd50 Author: Tomeu Vizoso <tomeu.vizoso@collabora.com> Date: Wed May 22 12:57:54 2013 +0200 Stop animations in the screen shield when logging in Otherwise there could be a race when the animation to show the shield is still running when the user authenticates successfully. https://bugzilla.gnome.org/show_bug.cgi?id=700839
Did a bit of a mess here, sorry about that. Please disregard the previous comment.