After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700768 - Support libquvi 0.9
Support libquvi 0.9
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-21 09:03 UTC by Bastien Nocera
Modified: 2013-07-01 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
plparse: Port to libquvi 0.9 (6.43 KB, patch)
2013-06-21 11:17 UTC, Bastien Nocera
none Details | Review
plparse: Port to libquvi 0.9 (14.74 KB, patch)
2013-07-01 12:10 UTC, Bastien Nocera
none Details | Review
plparse: Move signal emission to separate function (2.37 KB, patch)
2013-07-01 13:26 UTC, Bastien Nocera
committed Details | Review
plparse: Make split-off functions internal (2.33 KB, patch)
2013-07-01 13:26 UTC, Bastien Nocera
committed Details | Review
plparse: Move string fixing to separate function (2.19 KB, patch)
2013-07-01 13:26 UTC, Bastien Nocera
committed Details | Review
plparse: Port to libquvi 0.9 (15.33 KB, patch)
2013-07-01 13:36 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-05-21 09:03:17 UTC
Unlike libquvi 0.4, libquvi 0.9 is GPLv3+, which is incompatible with our LGPL (if we want non-GPL apps to link to the library), so we'll need to use a shim.

The easiest would be to create a helper binary that would link to libquvi and handle the parsing. That helper would be GPLv3+.
Comment 2 Bastien Nocera 2013-06-21 11:17:58 UTC
Created attachment 247423 [details] [review]
plparse: Port to libquvi 0.9

XXX Not for committing, libquvi's AGPL is incompatible with
our LGPL.
Comment 3 Bastien Nocera 2013-07-01 12:10:51 UTC
Created attachment 248130 [details] [review]
plparse: Port to libquvi 0.9

XXX Unfinished
Comment 4 Bastien Nocera 2013-07-01 13:26:29 UTC
Created attachment 248137 [details] [review]
plparse: Move signal emission to separate function
Comment 5 Bastien Nocera 2013-07-01 13:26:40 UTC
Created attachment 248138 [details] [review]
plparse: Make split-off functions internal

So they can be used by the new quvi code.
Comment 6 Bastien Nocera 2013-07-01 13:26:49 UTC
Created attachment 248139 [details] [review]
plparse: Move string fixing to separate function
Comment 7 Bastien Nocera 2013-07-01 13:36:12 UTC
Created attachment 248144 [details] [review]
plparse: Port to libquvi 0.9
Comment 8 Bastien Nocera 2013-07-01 13:41:00 UTC
Attachment 248137 [details] pushed as 5ab0f92 - plparse: Move signal emission to separate function
Attachment 248138 [details] pushed as 5785325 - plparse: Make split-off functions internal
Attachment 248139 [details] pushed as 7ec29b4 - plparse: Move string fixing to separate function
Attachment 248144 [details] pushed as 2497001 - plparse: Port to libquvi 0.9