After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700763 - Use GFile instead of stdio in mp4_tag.c in EasyTAG
Use GFile instead of stdio in mp4_tag.c in EasyTAG
Status: RESOLVED OBSOLETE
Product: easytag
Classification: Other
Component: general
master
Other Linux
: Normal normal
: 2.1
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks: 700050
 
 
Reported: 2013-05-21 05:16 UTC by Abhinav
Modified: 2013-05-21 07:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch will fix the above bug (3.31 KB, patch)
2013-05-21 05:18 UTC, Abhinav 		rejected Details | Review

Description Abhinav 2013-05-21 05:16:20 UTC 
Currently EasyTAG uses stdio i.e. functions fopen, fclose, in mp4_tag.c. These stdio could be replaced with much better and high level GFile from GIO. This will simplify file handling, name of file handling encoding, could also help in making Asynchronous I/O and with this EasyTAG could be used over NFS and CIFS/Samba shares.
Comment 1 Abhinav 2013-05-21 05:18:25 UTC 
Created attachment 244896 [details] [review]
This patch will fix the above bug
Comment 2 David King 2013-05-21 07:19:16 UTC 
Comment on attachment 244896 [details] [review]
This patch will fix the above bug

I removed this checking entirely on master in commit 
commit b4ef8260a60d7a7642728cd01e58624b5343fef4, as it was unnecessary.