After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700648 - Don't use object.set_property()
Don't use object.set_property()
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-19 17:49 UTC by Giovanni Campagna
Modified: 2013-05-20 19:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't use g_object_set_property() manually (8.26 KB, patch)
2013-05-19 17:49 UTC, Giovanni Campagna
none Details | Review
Don't use g_object_set_property() manually (8.45 KB, patch)
2013-05-20 16:06 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2013-05-19 17:49:23 UTC
See patch
Comment 1 Giovanni Campagna 2013-05-19 17:49:45 UTC
Created attachment 244725 [details] [review]
Don't use g_object_set_property() manually

In gjs, GObject properties are exposed as JS properties, and not
only using them is part of the style guide, it is also more correct
because set_property() converts the JS value without the GParamSpec
type information, which can then break.

In general, the style conventions mandate avoiding setter methods
when GObject properties exist, but the diff would be huge at this
point.
Comment 2 Seif Lotfy 2013-05-20 02:37:18 UTC
Thanks a lot Giovanni, I however merged some other stuff before merging yours. Can you rebase you patch ontop of master?
Comment 3 Giovanni Campagna 2013-05-20 16:06:41 UTC
Created attachment 244831 [details] [review]
Don't use g_object_set_property() manually

In gjs, GObject properties are exposed as JS properties, and not
only using them is part of the style guide, it is also more correct
because set_property() converts the JS value without the GParamSpec
type information, which can then break.

In general, the style conventions mandate avoiding setter methods
when GObject properties exist, but the diff would be huge at this
point.

Here you are, it was an easy rebase.
Comment 4 Seif Lotfy 2013-05-20 19:06:54 UTC
Thanks pushed to master