GNOME Bugzilla – Bug 700648
Don't use object.set_property()
Last modified: 2013-05-20 19:06:54 UTC
See patch
Created attachment 244725 [details] [review] Don't use g_object_set_property() manually In gjs, GObject properties are exposed as JS properties, and not only using them is part of the style guide, it is also more correct because set_property() converts the JS value without the GParamSpec type information, which can then break. In general, the style conventions mandate avoiding setter methods when GObject properties exist, but the diff would be huge at this point.
Thanks a lot Giovanni, I however merged some other stuff before merging yours. Can you rebase you patch ontop of master?
Created attachment 244831 [details] [review] Don't use g_object_set_property() manually In gjs, GObject properties are exposed as JS properties, and not only using them is part of the style guide, it is also more correct because set_property() converts the JS value without the GParamSpec type information, which can then break. In general, the style conventions mandate avoiding setter methods when GObject properties exist, but the diff would be huge at this point. Here you are, it was an easy rebase.
Thanks pushed to master