After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700599 - axis scale: cannot set manual scale, if it matches auto scale
axis scale: cannot set manual scale, if it matches auto scale
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
1.12.x
Other Linux
: Normal normal
: 2.0
Assigned To: Jean Bréfort
Jody Goldberg
: 747619 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-18 19:31 UTC by John Denker
Modified: 2015-04-13 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
spreadsheet to exhibit axis bugs (3.79 KB, application/x-gnumeric)
2013-05-18 19:31 UTC, John Denker
  Details
Proposed patch (692 bytes, patch)
2015-04-11 15:02 UTC, Jean Bréfort
committed Details | Review
Date axis sample (2.54 KB, application/x-gnumeric)
2015-04-12 04:06 UTC, Morten Welinder
  Details

Description John Denker 2013-05-18 19:31:39 UTC
Created attachment 244652 [details]
spreadsheet to exhibit axis bugs

Recipe:  
 1) Draw a graph.  Allow the axes to be automatically scaled.
 2) On the Scale tab, unclick the Automatic scale.  Click "Apply".
 3) Re-examine the properties.  Find that automatic scaling has
  mysteriously and very unhelpfully been turned back on.
 
Workaround:
  -- Uncheck "automatic" and change the scale from (say) 0.6 to 0.60001
   Click "Apply".
  -- This seems to work.  However, this can lead to other problems, as 
   described elsewhere;  see Bug 700598
Comment 1 Jean Bréfort 2013-05-19 06:44:38 UTC
I see the point, but I'm wondering why you need to change the value to manual if you don't actually change the value. For now the solution is not to add a small increment to the value, but you change it to anything else and then back to the auto value. Once you have changed the value, it becomes really manual.

On the technical side of the issue, I'm not sure this can be fixed without an API break.
Comment 2 Andreas J. Guelzow 2013-05-19 15:14:25 UTC
Jean, an obvious use case is if you set up a cart and expect to change the data it uses afterwards. In this case it may be desirable to fix the axis range to a specific value even if it happens to be the current value.
Comment 3 Jean Bréfort 2013-05-19 21:28:33 UTC
Just click on the entry and validate, this will really set the value and make it manual. There is actually no need to change the value twice as I wrote in comment #2.
Comment 4 Andreas J. Guelzow 2013-05-31 22:47:11 UTC
Jean, doesn't your 'workaround' of comment #3 really provide a way of implementing this without an API break?
Comment 5 Jean Bréfort 2013-06-01 05:16:58 UTC
What I describe in comment #3 actually already works. The issue is that it should work even without validating the entry.
Comment 6 Andreas J. Guelzow 2013-06-01 17:43:43 UTC
Jean, my thought was that appending 
gtk_widget_activate (GTK_WIDGET (closure->editor));
to cb_enable_dim in gog-axis.c should have the same effect as "Just click on the entry and validate".

It doesn't seem to work though.
Comment 7 Jean Bréfort 2015-04-10 13:56:16 UTC
*** Bug 747619 has been marked as a duplicate of this bug. ***
Comment 8 Jean Bréfort 2015-04-11 15:02:31 UTC
Created attachment 301366 [details] [review]
Proposed patch

Plase test this patch.
Comment 9 John Denker 2015-04-11 17:27:37 UTC
(In reply to Jean Bréfort from comment #8)

> Plase test this patch.

I tested the patch.  Yes, it makes the symptoms go away.

I did only an empirical operational test.  I don't
understand the root cause well enough to review
the code itself.
Comment 10 Morten Welinder 2015-04-12 04:04:15 UTC
Works for me.
Comment 11 Morten Welinder 2015-04-12 04:06:43 UTC
Created attachment 301391 [details]
Date axis sample

With this sample, unclicking automatic for the X axis changes from
a date formatted value to a plain number.
Comment 12 Jean Bréfort 2015-04-12 04:34:51 UTC
Ah, I see, I did not check for the format. Things are then more involved and might need an API break.
Comment 13 Morten Welinder 2015-04-12 16:40:48 UTC
Maybe, but in the meantime let's commit this patch.  Even with that glitch,
this is far better than without.
Comment 14 Jean Bréfort 2015-04-12 19:35:34 UTC
Review of attachment 301366 [details] [review]:

Patch commited.
Comment 15 Jean Bréfort 2015-04-13 12:56:14 UTC
Fixed the date issue.

This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.