GNOME Bugzilla – Bug 700557
autoreconf -i fails in cases of ltmain.sh mismatch
Last modified: 2013-11-18 11:44:11 UTC
autotools.py's autoreconf -i (line 244 in master as of this writing) call fails if there's already an ltmain.sh in srcdir and the installed libtool is of a different version -- not an uncommon occurence when dealing with tarballs. Changing the call to autoreconf -fi overcomes the problem and should be otherwise harmless.
Created attachment 246250 [details] [review] Use autoreconf -fi to force replacement of ltmain.sh Maybe a patch will get someone's attention, and in the meantime I can set up gtk-osx-build-setup.sh to apply it.
Review of attachment 246250 [details] [review]: Maybe you need to update the docs in doc/C/index.docbook
Created attachment 246517 [details] [review] Use autoreconf -fi to force replacement of ltmain.sh OK, done. I went ahead and hand-edited the relevant po files as well, since that bit is in English in the msgstr for all of them (though a couple don't have that string translated).
I've been running jhbuild with this patch applied since a while and I've not found any issue. Javier, is ok to push this patch to master?
Comment on attachment 246517 [details] [review] Use autoreconf -fi to force replacement of ltmain.sh Sure, go for it, sorry for the delay on the reply
The following fix has been pushed: b822e83 Bug 700557 - autoreconf -i fails in cases of ltmain.sh mismatch
(In reply to comment #5) > Sure, go for it, sorry for the delay on the reply No worries. :D Pushed, thank you for the review and to John for the patch!