After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700485 - scrollbar looks bad in classic mode menus
scrollbar looks bad in classic mode menus
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-16 21:17 UTC by William Jon McCann
Modified: 2013-06-07 18:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (59.24 KB, image/png)
2013-05-16 21:17 UTC, William Jon McCann 		  Details
Style scrollbar in classic bubbles (1.48 KB, patch)
2013-05-22 16:51 UTC, Jakub Steiner 		needs-work Details | Review
Style scrollbar in classic bubbles (1.14 KB, patch)
2013-05-27 14:27 UTC, Jakub Steiner 		committed Details | Review

Description William Jon McCann 2013-05-16 21:17:59 UTC 
Created attachment 244468 [details]
screenshot

The scrollbar doesn't really fit in and looks bad in the classic mode menus.

The style was designed for a dark theme.
Comment 1 Jakub Steiner 2013-05-22 16:51:46 UTC 
Created attachment 245072 [details] [review]
Style scrollbar in classic bubbles
Comment 2 Florian Müllner 2013-05-22 17:05:12 UTC 
Review of attachment 245072 [details] [review]:

::: data/gnome-classic.css
@@ +96,3 @@
   }
 
+

Unrelated whitespace changes

@@ +101,3 @@
     spinner-image: url("classic-process-working.svg");
   }
+  

dto.

@@ +173,3 @@
+  .popup-menu StScrollBar StButton#vhandle, .popup-menu StScrollBar StButton#hhandle {
+    border-color: #e9e9e9;
+    border-width: 3px;

Not sure about the width change - it looks like a workaround for a bug in the applications-menu extension (and one that only works in classic mode at that); should be fixed in the extension instead
Comment 3 Florian Müllner 2013-05-22 17:54:22 UTC 
(In reply to comment #2)
> it looks like a workaround for a bug in the applications-menu extension [...]
> and should be fixed in the extension instead

See bug 700852, fixed in both master and 3-8.
Comment 4 Jakub Steiner 2013-05-27 14:27:00 UTC 
Created attachment 245386 [details] [review]
Style scrollbar in classic bubbles
Comment 5 Florian Müllner 2013-05-27 15:04:39 UTC 
Review of attachment 245386 [details] [review]:

LGTM
Comment 6 Florian Müllner 2013-06-07 18:18:49 UTC 
Attachment 245386 [details] pushed as 6f57211 - Style scrollbar in classic bubbles