After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700451 - Support Facebook
Support Facebook
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
: 700452 (view as bug list)
Depends on: 701499 701500
Blocks:
 
 
Reported: 2013-05-16 11:55 UTC by Debarshi Ray
Modified: 2013-11-29 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add PhotosFacebookItem (12.93 KB, patch)
2013-11-28 18:15 UTC, Debarshi Ray 		none Details | Review
item-manager: Create a FacebookItem when we get one (1.18 KB, patch)
2013-11-28 18:16 UTC, Debarshi Ray 		needs-work Details | Review
Fixed the tracker identifier name (1.10 KB, patch)
2013-11-28 19:02 UTC, Álvaro Peña 		reviewed Details | Review
Start the miner from the application (2.51 KB, patch)
2013-11-28 19:24 UTC, Álvaro Peña 		reviewed Details | Review
Add PhotosFacebookItem (12.92 KB, patch)
2013-11-29 11:45 UTC, Debarshi Ray 		committed Details | Review
application: Start the Facebook miner (2.52 KB, patch)
2013-11-29 11:45 UTC, Debarshi Ray 		committed Details | Review
properties-dialog: Show the source for Facebook items (1.36 KB, patch)
2013-11-29 11:46 UTC, Debarshi Ray 		committed Details | Review
item-manager: Create a FacebookItem when we get one (1.26 KB, patch)
2013-11-29 11:52 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-05-16 11:55:52 UTC 
Pickup Facebook accounts from GNOME Online Accounts and let the user access photos from Facebook.
Comment 1 Debarshi Ray 2013-05-16 12:04:27 UTC 
*** Bug 700452 has been marked as a duplicate of this bug. ***
Comment 2 Álvaro Peña 2013-08-21 12:06:32 UTC 
I have push (in a new branch: wip/facebook) an initial implementation of the Facebook item to show the photos stored by the Facebook miner.

Take a look at: https://git.gnome.org/browse/gnome-photos/commit/?h=wip/facebook&id=28d36c625f073fb24d306b8db0d132eb6bbb0f09
Comment 3 Debarshi Ray 2013-11-28 18:15:17 UTC 
Thank you Álvaro for progressing with the wip/facebook branch. Somehow the branch is not rebased properly, so I went ahead and fixed it locally. I am attaching the patches.
Comment 4 Debarshi Ray 2013-11-28 18:15:43 UTC 
Created attachment 263046 [details] [review]
Add PhotosFacebookItem
Comment 5 Debarshi Ray 2013-11-28 18:16:09 UTC 
Created attachment 263047 [details] [review]
item-manager: Create a FacebookItem when we get one
Comment 6 Debarshi Ray 2013-11-28 18:33:08 UTC 
Currently I am getting this crash with my Facebook account:

** (gnome-photos:11128): ERROR **: Can't get the photo from the Facebook Graph

(gdb) bt

+ Trace 232851

  • #0 g_logv
    at gmessages.c line 989
  • #1 g_log
    at gmessages.c line 1025
  • #2 photos_facebook_item_create_thumbnail
    at photos-facebook-item.c line 85
  • #3 photos_base_item_create_thumbnail_in_thread_func
    at photos-base-item.c line 229
  • #4 g_thread_pool_thread_proxy
    at gthreadpool.c line 309
  • #5 g_thread_proxy
    at gthread.c line 798
  • #6 start_thread
    at pthread_create.c line 309
  • #7 clone
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 111 






Comment 7


Álvaro Peña





          2013-11-28 19:02:52 UTC
        



Created attachment 263058 [details] [review]
Fixed the tracker identifier name






Comment 8


Álvaro Peña





          2013-11-28 19:24:49 UTC
        



Created attachment 263059 [details] [review]
Start the miner from the application






Comment 9


Debarshi Ray





          2013-11-29 11:42:05 UTC
        



Review of attachment 263058 [details] [review]:

Oh, yes. Ofcourse that explains the crash. This should me squashed with the previous commit.






Comment 10


Debarshi Ray





          2013-11-29 11:42:48 UTC
        



Review of attachment 263059 [details] [review]:

Looks good. You are missing the URL to the bug in the commit message.






Comment 11


Debarshi Ray





          2013-11-29 11:45:08 UTC
        



Created attachment 263105 [details] [review]
Add PhotosFacebookItem






Comment 12


Debarshi Ray





          2013-11-29 11:45:46 UTC
        



Created attachment 263106 [details] [review]
application: Start the Facebook miner






Comment 13


Debarshi Ray





          2013-11-29 11:46:19 UTC
        



Created attachment 263107 [details] [review]
properties-dialog: Show the source for Facebook items






Comment 14


Debarshi Ray





          2013-11-29 11:51:55 UTC
        



Review of attachment 263047 [details] [review]:

::: src/photos-item-manager.c
@@ +286,3 @@
       if (g_str_has_prefix (identifier, "flickr:") || g_str_has_prefix (identifier, "photos:collection:flickr:"))
         ret_val = photos_flickr_item_new (cursor);
+      else if (g_str_has_prefix (identifier, "facebook:"))

This does not cover Facebook collections. See the condition for Flickr above.






Comment 15


Debarshi Ray





          2013-11-29 11:52:53 UTC
        



Created attachment 263108 [details] [review]
item-manager: Create a FacebookItem when we get one






Comment 16


Debarshi Ray





          2013-11-29 11:59:10 UTC
        



Thank you Álvaro for your efforts over the last several months. I am sure lots of people would be glad to have this feature.