GNOME Bugzilla – Bug 700404
port to freerdp from rdesktop
Last modified: 2013-07-03 15:07:15 UTC
Alternatively, we could add a separate plugin using freerdb with a configure-time switch.
Created attachment 248223 [details] [review] Default to FreeRDP if available Hi, the attached patch modifies vinagre's configure.ac file so that is use FreeRDP as RDP client if it is available (it uses rdesktop if xfreerdp is not available). It adds configure switch --disable-freerdp for disabling this. It also modifies an error string which contains "rdesktop" so it shows correct binary name if shown. I've replaced all occurrences of "rdesktop" in *.po files by %s (but it is not shown at all now because of a small bug when checking "title" string in show_error_dialog()). The only difference when run is that it has different default resolution (1024x768) compared to rdesktop (800x600). Regards Marek
Created attachment 248225 [details] [review] Default to FreeRDP if available (gnome-3-8)
Review of attachment 248225 [details] [review]: I think that it would be fine in this case to depend on freerdp instead of rdesktop, and remove the option to use rdesktop entirely.
Review of attachment 248223 [details] [review]: Ah, sorry, I should have reviewed the patch destined for master. This change is fine for master, after making it use freerdp unconditionally, but I do not think it should go to the 3.8 branch.
Created attachment 248316 [details] [review] Use xfreerdp for RDP support This patch just replaces all occurrences of "rdesktop" by "xfreerdp" (also in po files). I've removed the "AC_PATH_PROG([RDESKTOP_PROGRAM], [rdesktop], [rdesktop])" because the RDESKTOP_PROGRAM variable is not used anywhere.
Comment on attachment 248316 [details] [review] Use xfreerdp for RDP support Looks fine, please push to master.
Comment on attachment 248316 [details] [review] Use xfreerdp for RDP support Thank you for the review. I've pushed the patch to master.