After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700137 - network: properly namespace wireless security boxed types
network: properly namespace wireless security boxed types
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-11 22:32 UTC by Giovanni Campagna
Modified: 2013-05-13 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: properly namespace wireless security boxed types (4.27 KB, patch)
2013-05-11 22:32 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-05-11 22:32:39 UTC 
These types appear with the same name in libnm-gtk, but they're
not shared because they come from different code, so they
need namespacing.
This prevents a crash that happens if you open a wifi property
dialog and then click "Connect to hidden network"
Comment 1 Giovanni Campagna 2013-05-11 22:32:42 UTC 
Created attachment 243866 [details] [review]
network: properly namespace wireless security boxed types
Comment 2 Bastien Nocera 2013-05-13 07:25:34 UTC 
Review of attachment 243866 [details] [review]:

Looks good. Please commit to gnome-3-8 and master.

::: panels/network/wireless-security/nm-connection-editor-to-network-panel.patch
@@ +159,3 @@
+        if (!type_id) {
+-               type_id = g_boxed_type_register_static ("WirelessSecurity",
++               g_resources_register (wireless_security_get_resource ());

Is this a whitespace only change? Please remove it.
Comment 3 Giovanni Campagna 2013-05-13 19:42:25 UTC 
Attachment 243866 [details] pushed as d59a1b0 - network: properly namespace wireless security boxed types