GNOME Bugzilla – Bug 700076
Additional plugins not functional in gedit 3.8
Last modified: 2013-05-19 12:00:04 UTC
In gedit's user help additional plugins are no more functional and are needed to be removed from there and new plugins if exist should be introduced in place of older non functional ones.
What does "no more functional" exactly mean? Please provide steps to reproduce and/or error messages, if possible, if you refer to the documentation itself. If you refer to the plugins documented, a list of affected plugins would be welcome.
Created attachment 243791 [details] [review] 0001-Removed-non-functional-additional-plugins-from-gedit.patch
Why do you think they are not functional?
sorry, actually additional plugins which works with gedit 3.6 or older are not compatible with gedit 3.8 because loader for gedit 3.8 is python3 where as gedit 3.0-3.6 loader is python hence the older additional plugins dont work in gedit 3.8 and need newer version with loader python3. The list of affected plugins which works with gedit 3.8 are on https://live.gnome.org/Gedit/Plugins.
thank you nacho :)
Created attachment 244206 [details] [review] 0001-removed-obsolete-gedit-additional-plugins.patch
Review of attachment 244206 [details] [review]: Those pages need to be removed from the help/Makefile.am : once the patch is applied, the project should fail to build because the files are in the Makefile, but not in the repository. Once you remove these pages from the Makefile, this should no longer be a problem. One of the other pages also links to gedit-plugins-text-size, the link should be removed.
Created attachment 244237 [details] [review] 0001-removed-obsolete-gedit-additional-plugins-bug-700076.patch
Created attachment 244242 [details] [review] removed-obsolete-gedit-additional-plugins-bug-700076
Comment on attachment 244242 [details] [review] removed-obsolete-gedit-additional-plugins-bug-700076 The patch was pushed to master in commit ca59dc566b7f948086be85b29f8da205d8f4c83c
Reopening because I do not understand the reason those pages have been removed... why? Those plugins are functional, they are in the gedit-plugins package, they are maintained by us and they work perfectly
(In reply to comment #11) > why? Those plugins are functional, they are in the gedit-plugins package, they > are maintained by us and they work perfectly I think that Shobha was confused by the fact that the extra plugins are in a different repository, so as far as she could see, they were not present in gedit. I have to admit that I also missed this. Since the *extra* plugin help should not be visible when it is not installed, the correct thing to do with the help would actually be for the help to be installed alongside the additional plugins (so be inside that repository) and for the pages to just be dropped into the gedit help on installing the extra plugins. Would you be happy to go along with that?
yes, very happy :)
Created attachment 244475 [details] [review] Move help for extra plugins into gedit-plugins This patch for gedit-plugins builds for me and installs the help correctly into the same place as the gedit help.
Review of attachment 244475 [details] [review]: It looks good to me.
Comment on attachment 244475 [details] [review] Move help for extra plugins into gedit-plugins Pushed to gedit-plugins master[1] in commit 9fafdc035f3f26b18025919294a6315161588d84 [1] https://git.gnome.org/browse/gedit-plugins/commit/?id=9fafdc035f3f26b18025919294a6315161588d84
Something is wrong with the HELP_ID variable in help/Makefile.am. This is the message shown in the translations statistics page [1]: HELP_ID doesn't point to a real file, probably a macro. Maybe we should add the following line at the end of the help's Makefile?: -include $(top_srcdir)/git.mk [1] https://l10n.gnome.org/module/gedit-plugins/
I think I know where is the problem with the HELP_ID variable... there is no index.page file in the help/C folder, so Damned Lies page crashes when generating the POT file. It was discussed here for another module: https://mail.gnome.org/archives/gnome-i18n/2013-March/msg00057.html If you agree, I can create and commit a dummy index.page file to avoid this error.
(In reply to comment #18) > I think I know where is the problem with the HELP_ID variable... there is no > index.page file in the help/C folder, so Damned Lies page crashes when > generating the POT file. It was discussed here for another module: > > https://mail.gnome.org/archives/gnome-i18n/2013-March/msg00057.html > > If you agree, I can create and commit a dummy index.page file to avoid this > error. Thanks for that. I hope you don't mind, I wanted to try it as soon as possible and committed an index page myself. It appears to have done the trick!
Don't worry about it! I was going to commit it, but preferred to ask before. Thanks to you for doing it :) Can this bug be closed as Fixed?
I think that I have now finished all the moving of the help, closing bug as FIXED.