GNOME Bugzilla – Bug 700044
shapewipe sample pipeline won't work
Last modified: 2013-05-10 07:27:27 UTC
The pipeline itself need fixing as it was not fully ported to 1.0, aslo we should remove undeed (). After fixing that we get critical: GStreamer-CRITICAL **: gst_structure_set_name: assertion `IS_MUTABLE (structure)' failed Patches will follow ...
Created attachment 243755 [details] [review] [PATCH] shapewipe: Fix sample pipeline in documentation https://bugzilla.gnome.org/show_bug.cgi?id=700044 --- gst/shapewipe/gstshapewipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Created attachment 243756 [details] [review] [PATCH] shapewipe: Ensure caps are writable The exist one case where that we endup with original caps in ret, in which case we are not guaratied to have writable caps. Simply ensure this is the caps are writable before entering the loop. https://bugzilla.gnome.org/show_bug.cgi?id=700044 --- gst/shapewipe/gstshapewipe.c | 1 + 1 file changed, 1 insertion(+)
Created attachment 243757 [details] [review] [PATCH] shapewipe: Can't map twice the same buffer for writing I took the opportunity to simplify that code a bit. We now use gst_buffer_make_writable() to make the buffer writable and map twice the same buffer, with first map being read/write, and second read only. This get rid of the critical: GStreamer-CRITICAL **: gst_structure_set_name: assertion `IS_MUTABLE https://bugzilla.gnome.org/show_bug.cgi?id=700044 --- gst/shapewipe/gstshapewipe.c | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-)
All pushed, thanks :)