After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699971 - oggmux: Sends a segment event before sending a caps event.
oggmux: Sends a segment event before sending a caps event.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 699763 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-09 01:34 UTC by Mathieu Duponchelle
Modified: 2013-05-16 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch to fix the issue (1.07 KB, patch)
2013-05-09 01:35 UTC, Mathieu Duponchelle 		needs-work Details | Review
Proposed patch to fix the issue (1.41 KB, patch)
2013-05-09 21:56 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2013-05-09 01:34:31 UTC 
oggmux sends a segment event in send_start_events, which is called before send_headers. Can we assume that we will necessarily get a segment event to forward ? If so, the proposed patch should be enough, as it only removes the segment sending from send_start_events.
Comment 1 Mathieu Duponchelle 2013-05-09 01:35:28 UTC 
Created attachment 243657 [details] [review]
Proposed patch to fix the issue
Comment 2 Sebastian Dröge (slomo) 2013-05-09 07:03:02 UTC 
Comment on attachment 243657 [details] [review]
Proposed patch to fix the issue

No, in pull mode we need to generate a segment event ourselves.
Comment 3 Sebastian Dröge (slomo) 2013-05-09 07:04:54 UTC 
Oh, oggmux, not oggdemux. But we don't forward any segment events in oggmux, we have to create our own. So just move this code to the place where oggmux sends the caps event.
Comment 4 Mathieu Duponchelle 2013-05-09 21:56:10 UTC 
Created attachment 243744 [details] [review]
Proposed patch to fix the issue

Done
Comment 5 Sebastian Dröge (slomo) 2013-05-10 07:29:25 UTC 
commit 46aff49316cfaf2ec44dc5e1fde780fbfc857823
Author: Mathieu Duponchelle <mathieu.duponchelle@epitech.eu>
Date:   Fri May 10 09:28:52 2013 +0200

    oggmux: don't send a segment event before the caps event
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699971
Comment 6 Tim-Philipp Müller 2013-05-16 20:37:10 UTC 
*** Bug 699763 has been marked as a duplicate of this bug. ***