After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699929 - GtkCheckMenuItem: remove an unused boolean field
GtkCheckMenuItem: remove an unused boolean field
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-05-08 12:13 UTC by Allison Karlitskaya (desrt)
Modified: 2013-05-09 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkCheckMenuItem: remove an unused boolean field (22.81 KB, patch)
2013-05-08 12:13 UTC, Allison Karlitskaya (desrt) 		none Details | Review
GtkCheckMenuItem: remove an unused boolean field (2.88 KB, patch)
2013-05-08 12:16 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-05-08 12:13:21 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-05-08 12:13:23 UTC 
Created attachment 243584 [details] [review]
GtkCheckMenuItem: remove an unused boolean field

always_show_toggle was always set to TRUE in _init() and never changed
from anywhere else.  Remove it and remove the if() statements based on
it.
Comment 2 Allison Karlitskaya (desrt) 2013-05-08 12:16:16 UTC 
Created attachment 243585 [details] [review]
GtkCheckMenuItem: remove an unused boolean field

always_show_toggle was always set to TRUE in _init() and never changed
from anywhere else.  Remove it and remove the if() statements based on
it.


Sorry -- obvious git mishap in the previous patch.
Comment 3 Cosimo Cecchi 2013-05-08 18:48:16 UTC 
Review of attachment 243585 [details] [review]:

Looks good to me
Comment 4 Matthias Clasen 2013-05-09 16:04:43 UTC 
Attachment 243585 [details] pushed as 434dfc2 - GtkCheckMenuItem: remove an unused boolean field