GNOME Bugzilla – Bug 699926
Improve support for applications using souphttpsrc as
Last modified: 2014-02-13 11:12:20 UTC
and URL downloader, like GstUriDownloader in hlsdemux.
Created attachment 243575 [details] [review] souphttpsrc: enable range requests in GST_STATE_NULL the seekable flags is set only when we have downloaded the headers which might be already too late. This add support for range requests in GST_STATE_NULL, useful for http client using this element, like in HLS.
Created attachment 243576 [details] [review] souphttpsrc: add better support for range requests
Created attachment 243577 [details] [review] souphttpsrc: add support for keep-alive sessions
Comment on attachment 243576 [details] [review] souphttpsrc: add better support for range requests Looks good but please say what exactly you do "better" there (adding support for a stop position of the range)
Comment on attachment 243577 [details] [review] souphttpsrc: add support for keep-alive sessions Not sure about this one... it will keep all connections to all servers open until the element is disposed or the server closes the connection? Shouldn't it close old connections if the new connection is for a new server? Also it should close all connections when going from READY->NULL, in NULL it should not have any system resources allocated anymore, like sockets.
Minor nitpick: please make guint32 seekable a proper enum type. And could you fix up the bug summary?
*** This bug has been marked as a duplicate of bug 702206 ***
Comment on attachment 243577 [details] [review] souphttpsrc: add support for keep-alive sessions This is now committed with some changes in uridownloader, basesrc and fixes for this commit. Should all work just fine now.