GNOME Bugzilla – Bug 699762
doesn't provide any feedback that a media format is unsupported
Last modified: 2013-05-17 14:22:41 UTC
When I try to play an mp3 file I don't get any feedback as to why it isn't playing. It also incorrectly puts the play button into the paused state. I do get an error message on the console however. JS LOG: URI:none JS LOG: Error:Gst.CoreError: Your GStreamer installation is missing a plug-in.,gstdecodebin2.c(3888): gst_decode_bin_expose (): /GstPlayBin:player/GstURIDecodeBin:uridecodebin0/GstDecodeBin:decodebin0: no suitable plugins found We should ensure the play controls are disabled when it isn't playing. And provide feedback to the user that the media isn't supported.
>And provide feedback to the user that the media isn't supported. Not sure about the way of notifying user - should we use notifications similar to gnome-documents (https://github.com/gnome-design-team/gnome-mockups/blob/master/documents/documents-notifications.png)?
We can also predict that some URLs cannot be played (using GstPbutils.Discoverer), but need a way to make some tracks unselectable. Could you provide a mockup and possibly gherkin scenarios for that case?
We should be able to tell if a format is unsupported before the user tries to play it, right? In that case I'd rather not use an in app notification but perhaps show the file as insensitive with a little symbolic "error" indicator in line with it. When clicking that it could display the properties page for the song which could include a button to go get the required codecs etc.
Created attachment 243606 [details] [review] Mark unplayable tracks with error icon, skip them With this patch tracks will be marked with error signs. We'll implement error dalog for them on next stages
Nice patch, but you are missing the functionality for the "Songs" view
Can we update this to apply to master?
Error sign on Songs view + now playing support
Created attachment 243975 [details] [review] Add error symbol nearby the tracks, which cannot be played due to missing codecs. Also implements now playing icon status for Songs view
Updated css and pushed as https://git.gnome.org/browse/gnome-music/commit/?id=33f0263d2d3fa4935d583d95e978b2984e748dfb
Proposed commit breaks album view
Created attachment 244429 [details] [review] Add error symbol nearby the tracks, which cannot be played due to missing codecs. Also implements now playing icon status for Songs view
Created attachment 244430 [details] [review] Add error symbol nearby the tracks, which cannot be played due to missing codecs. Also implements now playing icon status for Songs view
Review of attachment 244430 [details] [review]: ::: src/view.js @@ +48,3 @@ + "/usr/share/icons/gnome/scalable/status/dialog-error-symbolic.svg", + -1, 16, true); + This is wrong. We can't hardcode paths like this. Want to use the icon-names "media-playback-start-symbolic" and "dialog-error-symbolic". You can do this via the cell renderer directly instead of loading a pixbuf first.
Created attachment 244514 [details] [review] Add error symbol nearby the tracks, which cannot be played due to missing codecs. Also implements now playing icon status for Songs view
Review of attachment 244514 [details] [review]: ::: src/view.js @@ +409,3 @@ + columnNowPlaying.add_attribute(nowPlayingSymbolRenderer, "visible", 6); + columnNowPlaying.add_attribute(nowPlayingSymbolRenderer, "icon_name", 7); + listWidget.insert_column(columnNowPlaying, 0) Forgot some ; here ::: src/widgets.js @@ +296,3 @@ + if (!songWidget.can_be_played) + continue missing ;
Created attachment 244539 [details] [review] Add error symbol nearby the tracks, which cannot be played due to missing codecs. Also implements now playing icon status for Songs view Updated to follow GJS guidelines on semicolons
The following fix has been pushed: 3c018cf Add error symbol nearby the tracks, which cannot be played due to missing codecs.
Created attachment 244540 [details] [review] Add error symbol nearby the tracks, which cannot be played due to missing codecs. Also implements now playing icon status for Songs view Updated to follow GJS guidelines on semicolons