After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699451 - Global 'settings' variable can clash with the same in evolution-rspam
Global 'settings' variable can clash with the same in evolution-rspam
Status: RESOLVED FIXED
Product: evolution-rss
Classification: Other
Component: general
0.3.92
Other Linux
: Normal critical
: ---
Assigned To: evolution-rss-maint
evolution-rss-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-02 10:20 UTC by Milan Crha
Modified: 2013-05-04 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed evo-rss patch (7.40 KB, patch)
2013-05-02 12:56 UTC, Milan Crha 		committed Details | Review
proposed evo-rspam patch (7.59 KB, patch)
2013-05-02 12:57 UTC, Milan Crha 		committed Details | Review

Description Milan Crha 2013-05-02 10:20:54 UTC 
Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=886881

The reported has installed both evolution-rss and evolution-rspam, and it happened to him that the global GSettings 'settings' variable from rss was picked when reading in rspam plugin, which caused crash:
>   Settings schema 'org.gnome.evolution.plugin.rss' does not contain
>   a key named 'move-junk'

I do not know whether it's the cause for sure, but it's the most probable reason, what could happen here, from my point of view. Defining the variable static will help to prevent this 'variable interleaving'. Or renaming the global variable, though the best would be to not use global variables at all.
Comment 1 Milan Crha 2013-05-02 12:56:15 UTC 
Created attachment 243047 [details] [review]
proposed evo-rss patch

for evolution-rss;

This may do it.
Comment 2 Milan Crha 2013-05-02 12:57:22 UTC 
Created attachment 243048 [details] [review]
proposed evo-rspam patch

for evolution-rspam;

If I'm not mistaken, than Cooly also takes care of evo-rspam, thus here's a similar change for that too.
Comment 3 Lucian Langa 2013-05-04 10:10:51 UTC 
Thank you Milan,
created commit 871dbc2 for evolution-rss.
Comment 4 Lucian Langa 2013-05-04 20:32:45 UTC 
Commit 26cfd40 on evolution-rspam, slightly adapted. Thanks!