After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699335 - extensions: Adjust to PopupMenu API change
extensions: Adjust to PopupMenu API change
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-30 15:49 UTC by Florian Müllner
Modified: 2013-04-30 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-list: Adjust to PopupMenu API change (1.51 KB, patch)
2013-04-30 15:49 UTC, Florian Müllner 		committed Details | Review
xrandr-indicator: Adjust to PopupMenu API change (1.18 KB, patch)
2013-04-30 15:49 UTC, Florian Müllner 		committed Details | Review
workspace-indicator: Adjust to PopupMenu API change (1.47 KB, patch)
2013-04-30 15:50 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-04-30 15:49:46 UTC 
Obvious change, see patches.
Comment 1 Florian Müllner 2013-04-30 15:49:50 UTC 
Created attachment 242943 [details] [review]
window-list: Adjust to PopupMenu API change

setShowDot() has become setOrnament().
Comment 2 Florian Müllner 2013-04-30 15:49:55 UTC 
Created attachment 242944 [details] [review]
xrandr-indicator: Adjust to PopupMenu API change

setShowDot() has become setOrnament()
Comment 3 Florian Müllner 2013-04-30 15:50:00 UTC 
Created attachment 242945 [details] [review]
workspace-indicator: Adjust to PopupMenu API change

setShowDot() has become setOrnament()
Comment 4 Rui Matos 2013-04-30 16:50:27 UTC 
Review of attachment 242943 [details] [review]:

yes
Comment 5 Rui Matos 2013-04-30 16:50:38 UTC 
Review of attachment 242944 [details] [review]:

++
Comment 6 Rui Matos 2013-04-30 16:50:48 UTC 
Review of attachment 242945 [details] [review]:

++
Comment 7 Florian Müllner 2013-04-30 17:08:17 UTC 
Attachment 242943 [details] pushed as 8628add - window-list: Adjust to PopupMenu API change
Attachment 242944 [details] pushed as d903f1f - xrandr-indicator: Adjust to PopupMenu API change
Attachment 242945 [details] pushed as 8ba3bed - workspace-indicator: Adjust to PopupMenu API change

Those are fixes to go along the first 3.9 shell release, so I took the freedom of creating a stable 3-8 branch before pushing.