After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699312 - file browser: display icons beside every file
file browser: display icons beside every file
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-30 13:52 UTC by Adam Dingle
Modified: 2019-03-23 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug 699312 - Default to a generic icon in the file browser (1.11 KB, patch)
2013-06-18 14:05 UTC, Garrett Regier 		none Details | Review
Bug 699312 - Default to a generic icon in the file browser v2 (986 bytes, patch)
2013-06-18 14:20 UTC, Garrett Regier 		committed Details | Review

Description Adam Dingle 2013-04-30 13:52:05 UTC 
Currently the gedit file browser displays beside most, but not all, files.  For example, visit /usr/lib in the file browser and make sure that Show Binary is enabled.  You'll see that .a files have icons, but .so files do not.  If you visit /usr/bin, you'll see that most executables have icons but a few do not.

I think the file browser should display some sort of icon beside every file, both for consistency with Nautilus and because it would look nicer.
Comment 1 Ignacio Casal Quinteiro (nacho) 2013-04-30 13:58:23 UTC 
a bug in the mime type detector? or maybe we should fallback to a specific icon when that happens...
Comment 2 Adam Dingle 2013-04-30 13:59:45 UTC 
I'm not sure whether there's a type detection bug, but in any case if we can't figure out a type I think we should fall back on a generic icon like Nautilus does.
Comment 3 Garrett Regier 2013-06-18 14:05:50 UTC 
Created attachment 247149 [details] [review]
Bug 699312 - Default to a generic icon in the file browser

mclasen: "gnome-fs-regular works as a generic file icon"
Comment 4 Garrett Regier 2013-06-18 14:20:46 UTC 
Created attachment 247154 [details] [review]
Bug 699312 - Default to a generic icon in the file browser v2

Use the same icon as the GtkFileChooser.

(Coding style: using the same style as the rest of the function!)
Comment 5 Ignacio Casal Quinteiro (nacho) 2013-06-18 14:28:06 UTC 
Review of attachment 247154 [details] [review]:

Go ahead.
Comment 6 Garrett Regier 2013-06-18 14:37:11 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.