GNOME Bugzilla – Bug 69908
pangox and strtok_r
Last modified: 2004-12-22 21:47:04 UTC
pangox.c: In function `parse_gintset_spec': pangox.c:76: warning: implicit declaration of function `strtok_r' pangox.c:76: warning: assignment makes pointer from integer without a cast pangox.c:96: warning: assignment makes pointer from integer without a cast [...]
Hmmm, I thought I asked Robert Brady to fix that when that code was added. Anyways, a patch would be much appreciated if you don't have strtok_r on your machine; I doubt I'll get to this very soon.
Dang. I guess that's what I get for being overly brief. strtok_r is there, just not prototyped under default conditions. On Solaris (the system in question) this is probbaly harmless, but I'm not so sure elsewhere. #if defined(__STDC__) #if defined(__EXTENSIONS__) || defined(_REENTRANT) || \ (_POSIX_C_SOURCE - 0 >= 199506L) extern char *strtok_r(char *, const char *, char **); #endif /* defined(__EXTENSIONS__) || defined(_REENTRANT) .. */
Do you have any idea what the _correct_ thing to define would be to get this on Solaris? [ We probably still need a fallback for older systems, but that can probably wait until people complain ]
Can't do anything without more information. Please reopen from NEEDINFO if you add comments.
I think you need to lure a Sun guy over here to help. (Leaving NEEDINFO)
Seems to have been since fixed (and the code will be dying for Pango-1.4 anyways) *** This bug has been marked as a duplicate of 79472 ***