After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698896 - liveadder: What is the unit for "latency"?
liveadder: What is the unit for "latency"?
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.0.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-25 20:16 UTC by Brendan Long
Modified: 2013-05-18 11:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Brendan Long 2013-04-25 20:16:55 UTC
The documentation for liveadder says:

> The "latency" property
>  "latency"                  guint                 : Read / Write
> Amount of data to buffer.
> Default value: 60

It's confusing because it doesn't give a unit at all. 60 seconds? 60 milliseconds? 60 buffers?

I assume it means milliseconds based on this line in a different part of the page:

> Unlike the adder, the liveadder mixes the streams according the their timestamps and waits for some milli-seconds before trying doing the mixing.

If that's the case, I'd recommend changing the documentation to say:

> Number of milliseconds to buffer data

See: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-bad-plugins/html/gst-plugins-bad-plugins-liveadder.html
Comment 1 Nicolas Dufresne (ndufresne) 2013-04-26 12:14:28 UTC
(In reply to comment #0)
> It's confusing because it doesn't give a unit at all. 60 seconds? 60
> milliseconds? 60 buffers?

It's milliseconds, documentation shall be fixed.
Comment 2 Olivier Crête 2013-04-26 19:35:26 UTC
Fixed

commit 6e5db57d2446a753aaa76bee268e1f95600b14ce
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Fri Apr 26 15:33:18 2013 -0400

    liveadder: Document that the latency is in milliseconds
    
    Bug #698896