After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698888 - SDP session bandwidth not duplicated, causing segfault when freeing...
SDP session bandwidth not duplicated, causing segfault when freeing...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-25 19:14 UTC by Sebastian Rasmussen
Modified: 2013-04-26 06:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch fixing problem. (862 bytes, patch)
2013-04-25 19:15 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2013-04-25 19:14:50 UTC 
gst_sdp_message_add_bandwidth() failed to duplicate the bandwidth attribute name (compare gst_sdp_media_add_bandwidth()). This caused problems when calling gst_sdp_message_free() as it assumes that all attribute names are duplicated.

The attached patch fixes the problem.
Comment 1 Sebastian Rasmussen 2013-04-25 19:15:58 UTC 
Created attachment 242458 [details] [review]
Proposed patch fixing problem.
Comment 2 Sebastian Dröge (slomo) 2013-04-26 06:42:51 UTC 
commit f7e879aa18d874d21024093fd0f09e8ec7f24d26
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Thu Apr 25 21:10:04 2013 +0200

    sdp: Store a copy of the bandwidth string
    
    Otherwise we will free a string later that does not belong to us.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=698888