GNOME Bugzilla – Bug 698757
power: Adapt to new DBus interface for setting screen brightness
Last modified: 2013-06-23 00:18:05 UTC
Adapt to the interface changes in bug #698754.
Created attachment 242338 [details] [review] power: Adapt to new DBus interface for setting screen brightness
Review of attachment 242338 [details] [review]: Where do you check for the backlight not being present? ::: panels/power/cc-power-panel.c @@ +833,3 @@ g_dbus_proxy_call (priv->screen_proxy, + "org.freedesktop.DBus.Properties.Set", + g_variant_new_parsed ("('org.gnome.SettingsDaemon.Power.Screen'," Put this on one line, it's already quite indigest.
Created attachment 246440 [details] [review] power: Adapt to new DBus interface for setting screen brightness
Review of attachment 246440 [details] [review]: Looks good to commit after those changes. ::: panels/power/cc-power-panel.c @@ +855,3 @@ + /* set the slider */ + g_variant_get (result, "i", &brightness); + visible = brightness >= 0.0; () around the comparison part. @@ +862,1 @@ + if (visible) if (!visible) return; Saves you from reformatting/moving that code.
Attachment 246440 [details] pushed as e5c0be9 - power: Adapt to new DBus interface for setting screen brightness