After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698704 - [PATCH] Add VIM and Emacs modelines
[PATCH] Add VIM and Emacs modelines
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-23 22:38 UTC by Mattias Bengtsson
Modified: 2013-04-24 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add modelines for emacs and vim (2.78 KB, patch)
2013-04-23 22:38 UTC, Mattias Bengtsson 		committed Details | Review

Description Mattias Bengtsson 2013-04-23 22:38:24 UTC 
Created attachment 242295 [details] [review]
Add modelines for emacs and vim

This patch adds VIM and Emacs modelines to the js-files of gnome-maps.
Comment 1 Zeeshan Ali 2013-04-24 02:29:15 UTC 
Review of attachment 242295 [details] [review]:

::: src/application.js
@@ +1,2 @@
+/* -*- Mode: JS2; indent-tabs-mode: nil; js2-basic-offset: 4 -*- */
+/* vim: set et ts=4 sw=4: */

I'd prefer these to be at the end of the files. IIRC its all the same to editors?
Comment 2 Mattias Bengtsson 2013-04-24 19:15:09 UTC 
I just tried this quickly and then read up on this[1] and apparently emacs requires the line to be at the top, unless you're ok with a really verbose list style for setting the mode vars. I think we should just put them at the top, that's what I've seen most projects do.

--
1: http://www.delorie.com/gnu/docs/emacs/emacs_486.html
Comment 3 Zeeshan Ali 2013-04-24 19:57:46 UTC 
Ah ok.