After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698682 - GtkSpinButton: don't constantly recreate style contexts for buttons
GtkSpinButton: don't constantly recreate style contexts for buttons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-04-23 17:32 UTC by Owen Taylor
Modified: 2013-04-24 01:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkSpinButton: don't constantly recreate style contexts for buttons (5.81 KB, patch)
2013-04-23 17:32 UTC, Owen Taylor 		accepted-commit_now Details | Review

Description Owen Taylor 2013-04-23 17:32:10 UTC 
Cache the style contexts for the up and down panels, instead of recreating
them each time they are drawn or size requested. GtkSpinButtons were
many times slower to draw than other widgets because of the constant
style matching.
Comment 1 Owen Taylor 2013-04-23 17:32:12 UTC 
Created attachment 242271 [details] [review]
GtkSpinButton: don't constantly recreate style contexts for buttons
Comment 2 Benjamin Otte (Company) 2013-04-23 17:44:16 UTC 
Comment on attachment 242271 [details] [review]
GtkSpinButton: don't constantly recreate style contexts for buttons

looks good.
Comment 3 Matthias Clasen 2013-04-24 01:25:38 UTC 
this was pushed