After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698622 - Fix some regressions with the new workspaces code
Fix some regressions with the new workspaces code
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-22 22:25 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-04-22 22:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspace: Recalculate window positions when we have no layout (1.43 KB, patch)
2013-04-22 22:25 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
workspace: Invalidate the current layout when windows are added or removed (1.22 KB, patch)
2013-04-22 22:25 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-04-22 22:25:20 UTC 
See patches. This fixes a bad crasher that happens when closing
windows in the overview.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-04-22 22:25:23 UTC 
Created attachment 242179 [details] [review]
workspace: Recalculate window positions when we have no layout

If for any reason the current layout is invalidated, queue a
reposition.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-04-22 22:25:26 UTC 
Created attachment 242180 [details] [review]
workspace: Invalidate the current layout when windows are added or removed

If windows are removed or added, we shouldn't keep the old layout, as it's
not valid anymore. If windows are removed, this is especially bad, as the
rows contain references to the removed window objects, causing crashes.
Comment 3 Cosimo Cecchi 2013-04-22 22:30:08 UTC 
Review of attachment 242179 [details] [review]:

Looks good
Comment 4 Cosimo Cecchi 2013-04-22 22:31:17 UTC 
Review of attachment 242180 [details] [review]:

Okay
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-04-22 22:33:57 UTC 
Attachment 242179 [details] pushed as e1de397 - workspace: Recalculate window positions when we have no layout
Attachment 242180 [details] pushed as 8b3b91d - workspace: Invalidate the current layout when windows are added or removed