After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698609 - Confirm close
Confirm close
Status: RESOLVED DUPLICATE of bug 699269
Product: gnome-initial-setup
Classification: Applications
Component: general
0.9
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-22 19:45 UTC by Michael Wood
Modified: 2013-05-09 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Wood 2013-04-22 19:45:25 UTC
In first login mode perhaps we should prompt users with a confirmation of closure.

Adding a "Do you really want to quit" also allows us to have the option of allowing the user to accept all the defaults and quit.
Comment 1 Rui Matos 2013-04-23 16:49:09 UTC
When would this happen? There's no way to close the window before the reaching the summary page currently.
Comment 2 Michael Wood 2013-04-25 13:51:43 UTC
In the overview mode you can close it. When in user mode.
Comment 3 Allan Day 2013-04-25 14:31:11 UTC
I had imagined that the experience would be the same in first login or first boot - you're not in the user session proper until you've finished account setup.

CC'ing Jon and Jakub to confirm.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-04-25 15:13:28 UTC
(In reply to comment #3)
> I had imagined that the experience would be the same in first login or first
> boot - you're not in the user session proper until you've finished account
> setup.
> 
> CC'ing Jon and Jakub to confirm.

There's two modes: first boot mode to set up a new user account, and existing user mode for when an admin adds an account that they need to setup.

I think gnome-shell should hide the close button if we don't have the WM_DELETE feature on the window.
Comment 5 William Jon McCann 2013-04-25 15:42:58 UTC
I'm not sure I understand. Even if I have an account already created, say if we run the initial setup after a system upgrade, I expect the user experience to be the same as if I am creating an account for the first time. Specifically, that the tool runs in a special mode without the overview and multi-tasking.
Comment 6 Allan Day 2013-04-25 15:54:07 UTC
(In reply to comment #5)
> I'm not sure I understand. Even if I have an account already created, say if we
> run the initial setup after a system upgrade, I expect the user experience to
> be the same as if I am creating an account for the first time. Specifically,
> that the tool runs in a special mode without the overview and multi-tasking.

That's what I attempted to say (in case anyone was struggling to parse my terrible comment).
Comment 7 Michael Wood 2013-04-25 15:59:04 UTC
Having it run in a special mode seems a bit over the top in the first login case.

The number of times you'll want to modify it away from the current or system settings seems very minimal.
Comment 8 Matthias Clasen 2013-04-25 16:08:37 UTC
Doing a special shell mode for first-login will be hard. Or at least, it is not something we have any infrastructure - we would have to change the shell mode in the middle of a running session.
Comment 9 Matthias Clasen 2013-04-25 16:09:44 UTC
(In reply to comment #4)

> I think gnome-shell should hide the close button if we don't have the WM_DELETE
> feature on the window.

It does.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-04-25 16:56:47 UTC
(In reply to comment #8)
> Doing a special shell mode for first-login will be hard. Or at least, it is not
> something we have any infrastructure - we would have to change the shell mode
> in the middle of a running session.

We could log into the user's session in initial-setup mode, and then relogin into a regular session once done, but that would mean the user would have to re-enter their password.

(In reply to comment #9)
> (In reply to comment #4)
> 
> > I think gnome-shell should hide the close button if we don't have the WM_DELETE
> > feature on the window.
> 
> It does.

Then that means you can't close it from the overview. Case closed :)
Comment 11 Michael Wood 2013-04-26 10:35:43 UTC
http://imgur.com/W7tqnWA
http://imgur.com/TCxJIKP

GNOME Shell 3.8.0.1

Is it fixed in a newer version?
Comment 12 Matthias Clasen 2013-04-26 10:36:46 UTC
this was a misunderstanding, clarified in person. I was talking about the close button in the titlebar, not the overlayed one in the overview.
Comment 13 Michael Wood 2013-04-29 10:26:21 UTC
So what's the best way forward to resolve this bug? Fix it in G-S?
Comment 14 Jasper St. Pierre (not reading bugmail) 2013-04-29 13:59:42 UTC
Yeah, I think gnome-shell should respect WM_DELETE_FUNC. I'll file a patch set in Bugzilla.
Comment 15 Rui Matos 2013-05-09 19:33:05 UTC
Let's mark this as dupe of the shell bug.

*** This bug has been marked as a duplicate of bug 699269 ***