After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698534 - Support interpolation for line plots
Support interpolation for line plots
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-04-22 02:15 UTC by Andreas J. Guelzow
Modified: 2013-04-25 06:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Andreas J. Guelzow 2013-04-22 02:15:32 UTC
When opening the file attached to bug #698388 we get the warning:

Unknown interpolation type encountered: 'b-spline', using Bezier cubic spline instead.

But there does not seem to be _any_ interpolation type used in th eobjects of this file.
Comment 1 Andreas J. Guelzow 2013-04-22 04:37:04 UTC
I guess that this is simply a case of us not supporting interpolation types for line plots. Why not?
Comment 2 Jean Bréfort 2013-04-22 09:24:19 UTC
line plots are discrete plots. I don't see what an interpolation means in this situation.
Comment 3 Andreas J. Guelzow 2013-04-22 14:58:17 UTC
Jean, perhaps you could have a look at the file attached to bug #698388 and see whether we import it as the wrong plot style. LO uses interpolation, we import as lineplot and don't have interpolation there.
Comment 4 Jean Bréfort 2013-04-23 16:30:42 UTC
I suppose that closed splines don't apply to line plots. The issue is that there is no way to remove them from the list without breaking the API.

Do we also need interpolation in area plots?
Comment 5 Jean Bréfort 2013-04-24 09:13:33 UTC
Andreas, one more question: for line plots, Bezier cubic splines and natural cubic splines should be just identical, may be we should only use natural cubic splines there?
Comment 6 Andreas J. Guelzow 2013-04-24 19:46:57 UTC
Jean,

I am somewhat worried about the import from ODF. In ODF the interpolation type is part of the style. We translate the ODF style information into the Gnumeric/Goffice info when we read the style. Later when the style is applied to a graph we just check that the property exists and then pass the property value to the graph. For this to work it would be nice if all plots would accept all interpolation types.

Of course two interpolation types that yield the same result could then be mapped internally to one of them, it. with respect to line plots, Bezier cubic splines could be considered a synonym for natural cubic splines.
Comment 7 Jean Bréfort 2013-04-24 20:55:23 UTC
It is possible to replace the non supported interpolation types in gog_series_set_property().
Comment 8 Jean Bréfort 2013-04-24 20:58:48 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 9 Andreas J. Guelzow 2013-04-25 01:03:34 UTC
Jean, thank you very much!
It seems to me that the 'skip invalid data' checkbox has no effect.

If the file is opened in LO, the missing data points seem cause a break in the curves. In Gnumeric we interpolate across those missing values it seems even if the  skip invalid data is unchecked. (For xy-plots we also create breaks.)
Comment 10 Jean Bréfort 2013-04-25 05:43:57 UTC
Just forgot that, will fix.
Comment 11 Jean Bréfort 2013-04-25 06:22:35 UTC
Actually, I tried to have the same behavior than before: skip invalid for normal line plots and don't skip for all others. Just things don't work and I don't know why.
Comment 12 Jean Bréfort 2013-04-25 06:49:51 UTC
Fixed. The check box is now hidden for line and area plots (using a very bad hack), and there is a break for missing data in normal line plots (but not in stacked lines or in any area plot as before).