After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698519 - Potential text formatting/theme conflicts in comment tooltip
Potential text formatting/theme conflicts in comment tooltip
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-04-21 16:17 UTC by Andreas J. Guelzow
Modified: 2013-06-02 04:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (17.80 KB, image/png)
2013-04-22 16:02 UTC, Andreas J. Guelzow
Details

Description Andreas J. Guelzow 2013-04-21 16:17:21 UTC
It seems that commit
	5eb9a3153388f14a521a79fd3031c22da742c8ec 
partially broke display of the cell comments. We used to show the author, we do not any longer do that.

I am also not sure about showing the comments as a themed tooltip. Comments can include rich text formatting including font colours. This may not work with the themed tool tips.
Comment 1 Morten Welinder 2013-04-22 01:36:05 UTC
I was lazy with the comment author.  To do that, the one would put
Author: into a separate label and combine the two in a vbox.

I tested bold/italic/strikethrough.  They work perfectly fine.
Comment 2 Andreas J. Guelzow 2013-04-22 04:05:22 UTC
All the rich text formatting works fine. If we import a comment from Excel or LO it could become unreadable though if the font colour is set and does not work well with the background colour set by the theme.
Comment 3 Morten Welinder 2013-04-22 11:47:30 UTC
By-line is back.
Comment 4 Andreas J. Guelzow 2013-04-22 16:02:51 UTC
Created attachment 242144 [details]
screenshot

We might still need some fine tuning of the space above and below the author line. See screenshot.
Comment 5 Andreas J. Guelzow 2013-04-22 16:18:29 UTC
I have tuned the appearance by using spacing rather than padding.
Comment 6 Morten Welinder 2013-04-23 01:22:28 UTC
The conflict between the theme and the text isn't new, I think.

We could tag the contents as class "view" and avoid tagging it as a tooltip.
That would, I think, in many popular themes produce a white (or whitish)
background.  That solution bugs me a bit since this really is a tooltip
by function.
Comment 7 Andreas J. Guelzow 2013-04-23 01:29:15 UTC
The issues are font colour and font background. We could remove those attributes from the comment if we detect anything but a light theme background colour.
Comment 8 Andreas J. Guelzow 2013-06-02 04:19:52 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.