After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698372 - List box is too wide
List box is too wide
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Color
3.8.x
Other Linux
: Normal minor
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-19 15:04 UTC by António Fernandes
Modified: 2013-08-01 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
color: to shrink the list (1.51 KB, patch)
2013-07-30 19:09 UTC, Yosef Or Boczko 		needs-work Details | Review
Screenshot (106.57 KB, image/png)
2013-07-30 19:09 UTC, Yosef Or Boczko 		  Details
color: to shrink the list (1.36 KB, patch)
2013-07-31 15:45 UTC, Yosef Or Boczko 		committed Details | Review
what I see (27.66 KB, image/png)
2013-08-01 07:58 UTC, Richard Hughes 		  Details

Description António Fernandes 2013-04-19 15:04:56 UTC 
+++ This bug was initially created as a clone of Bug #691733 +++

The list is too wide. This has a few consequences:

 * The device name and switches/status label are too far away from each other
 * The profile name is too far from the "light bulb" icon
 * It is inconsistent with many of the other panels
Comment 1 Yosef Or Boczko 2013-07-30 19:09:35 UTC 
Created attachment 250502 [details] [review]
color: to shrink the list

It is inconsistent with many of the other panels:
134px in left-hand side of the list, 134px in right-hand side of the list,
22px from on bottom of the list and 22px from on top of the list.
Comment 2 Yosef Or Boczko 2013-07-30 19:09:54 UTC 
Created attachment 250503 [details]
Screenshot
Comment 3 Bastien Nocera 2013-07-31 15:04:53 UTC 
Review of attachment 250502 [details] [review]:

Could you move the lines back to their original place, so that only the number change?
Comment 4 Yosef Or Boczko 2013-07-31 15:45:02 UTC 
Created attachment 250555 [details] [review]
color: to shrink the list
Comment 5 Bastien Nocera 2013-07-31 15:50:12 UTC 
Review of attachment 250555 [details] [review]:

Looks good!
Comment 6 Yosef Or Boczko 2013-07-31 15:53:24 UTC 
Review of attachment 250555 [details] [review]:

pushed as 902e88c7ad826405f6588e1de5fac1848fe93396 - color: to shrink the list
Comment 7 Richard Hughes 2013-08-01 07:58:14 UTC 
Created attachment 250587 [details]
what I see

This is what I see. Not cool, and it does not match the mockup.
Comment 8 Yosef Or Boczko 2013-08-01 08:15:36 UTC 
Just need to add '<property name="height_request">430</property>', In order don't resizes when button appear
Comment 9 Richard Hughes 2013-08-01 09:33:12 UTC 
(In reply to comment #8)
> Just need to add '<property name="height_request">430</property>', In order
> don't resizes when button appear

No, that's not the point. Allan and Jakub did a design for the color panel last cycle, and we discussed the full-width thing v.s. the padding used by some other panels. We agreed the design worked better full width, and the design mockup was unchanged. The version restricting the default window to 50% of the window size makes the UX much more painful when the devices or profiles have long names.

I've reverted the patch in the color panel for now. I'd like you to discuss this with the guys in #gnome-design and get an altered mockup before re-commiting anything. Thanks.
Comment 10 Yosef Or Boczko 2013-08-01 13:08:41 UTC 
And the fix in bug #691733 is OK?