After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698301 - Username font shadow cut when user name is a bit long
Username font shadow cut when user name is a bit long
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
: 667124 694524 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-18 13:23 UTC by Lionel Landwerlin
Modified: 2013-05-24 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot issue (494.11 KB, image/jpeg)
2013-04-18 13:26 UTC, Lionel Landwerlin
  Details
Shadow rendering problem visualization (29.67 KB, image/png)
2013-05-07 22:44 UTC, Lionel Landwerlin
  Details
st-shadow: Fix offset shadow offscreen rendering (3.45 KB, patch)
2013-05-07 22:45 UTC, Lionel Landwerlin
committed Details | Review
Results after bug fix (22.67 KB, image/png)
2013-05-08 02:22 UTC, Lionel Landwerlin
  Details

Description Lionel Landwerlin 2013-04-18 13:23:59 UTC
I believe the screenshot is self explanatory.
Comment 1 Lionel Landwerlin 2013-04-18 13:24:22 UTC
Just just at the last letters :)
Comment 2 Lionel Landwerlin 2013-04-18 13:26:33 UTC
Created attachment 241827 [details]
Screenshot issue
Comment 3 Baptiste Mille-Mathias 2013-04-26 15:56:37 UTC
Just setting as NEW as confirmed, seen that on my machine.
Comment 4 Florian Müllner 2013-04-26 15:58:30 UTC
(In reply to comment #3)
> Just setting as NEW as confirmed, seen that on my machine.

We don't treat NEW any different than UNCONFIRMED ...
Comment 5 Matthias Clasen 2013-05-06 10:33:50 UTC
*** Bug 694524 has been marked as a duplicate of this bug. ***
Comment 6 Marco Scannadinari 2013-05-06 18:10:10 UTC
the shadowing is lost at a specific number of pixes for some reason - see Bug 694524's pictures for evidence
Comment 7 Lionel Landwerlin 2013-05-07 22:44:25 UTC
Created attachment 243547 [details]
Shadow rendering problem visualization

Here is a visualization of the rendering problem.

The shadows are currently rendered by painting the actor we want to apply shadow on, in an offscreen buffer. The problem is that when this actor has an allocation padding (ie allocation that isn't at 0x0 relatively to its parent), this padding is added within the offscreen buffer and as a result the shadow rendering is truncated because the offscreen buffer size is the size of the allocation box, not the allocation box + padding.

What you see in red are the offscreen buffer painted of the shadow. You can spot the initial gap which is the padding induced by the allocation.
Comment 8 Lionel Landwerlin 2013-05-07 22:45:13 UTC
Created attachment 243548 [details] [review]
st-shadow: Fix offset shadow offscreen rendering
Comment 9 Lionel Landwerlin 2013-05-08 02:22:19 UTC
Created attachment 243558 [details]
Results after bug fix

Attached the results after applying the fix, as you can see the shadow is not painting with an offset on the left and now fits into its allocated offscreen buffer.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-05-08 15:08:06 UTC
Review of attachment 243548 [details] [review]:

Works fine in testing, patch looks OK.
Comment 11 Lionel Landwerlin 2013-05-08 15:17:13 UTC
Committed to 3.8 and master.
Comment 12 Marco Scannadinari 2013-05-08 15:36:05 UTC
Isn't gdm able to be CSS-styled? Because then a simple box-shadow could be used...
Comment 13 Marco Scannadinari 2013-05-08 15:36:27 UTC
Isn't gdm able to be CSS-styled? Because then a simple box-shadow could be used...
Comment 14 Lionel Landwerlin 2013-05-08 15:38:50 UTC
Gdm is CSS-styled using St. But I don't get your point, box-shadow is different from text-shadow.
Comment 15 Florian Müllner 2013-05-08 15:40:25 UTC
(In reply to comment #13)
> Isn't gdm able to be CSS-styled? Because then a simple box-shadow could be
> used...

No, box-shadow is not the same as text-shadow - the former will cast a shadow from the background (e.g. a rectangle), the latter from the text content. Which is why CSS3 has *both* box-shadow and text-shadow properties :-)
Comment 16 Marco Scannadinari 2013-05-08 18:12:41 UTC
Sorry I went crazy for a second, but is there anything stopping text-shadow being used?
Comment 17 Jasper St. Pierre (not reading bugmail) 2013-05-08 18:14:28 UTC
(In reply to comment #16)
> Sorry I went crazy for a second, but is there anything stopping text-shadow
> being used?

It is used. Our implementation of text-shadow was wrong.
Comment 18 Florian Müllner 2013-05-24 14:10:38 UTC
*** Bug 667124 has been marked as a duplicate of this bug. ***