After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698279 - Crash when changing user account password
Crash when changing user account password
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.10
: 698130 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-04-18 09:35 UTC by Lionel Landwerlin
Modified: 2013-04-26 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix wrong user data pointer usage (1.36 KB, patch)
2013-04-18 09:36 UTC, Lionel Landwerlin 		none Details | Review
fix wrong user data pointer usage v2 (1.36 KB, patch)
2013-04-18 10:00 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2013-04-18 09:35:14 UTC 
Open the control center, go to user accounts, click the password of the current user, without doing changing anything click "Change" button, the control center ends up crashing.

The wrong callback data is being use to trigger a callback.
Comment 1 Lionel Landwerlin 2013-04-18 09:36:02 UTC 
Created attachment 241808 [details] [review]
fix wrong user data pointer usage
Comment 2 Lionel Landwerlin 2013-04-18 09:36:41 UTC 
One could argue that the "Change" button shouldn't be sensitive by default too.
Comment 3 Lionel Landwerlin 2013-04-18 10:00:30 UTC 
Created attachment 241809 [details] [review]
fix wrong user data pointer usage v2
Comment 4 Philippe "RzR" Coval 2013-04-18 10:25:49 UTC 
Review of attachment 241809 [details] [review]:

good to me
will also fix
https://bugzilla.gnome.org/show_bug.cgi?id=698130
Comment 5 Philippe "RzR" Coval 2013-04-18 10:26:09 UTC 
Review of attachment 241809 [details] [review]:

good to me
will also fix
https://bugzilla.gnome.org/show_bug.cgi?id=698130
Comment 6 Bastien Nocera 2013-04-22 15:36:40 UTC 
Review of attachment 241809 [details] [review]:

Totally correct.

I had fixed the same bug in ae108c45f33ebdbc2b2b859df931786fa66b196b, I should have reviewed the whole file :/

Needs committing to gnome-3-6 (if we ever do another release), gnome-3-8 and master please.
Comment 7 Lionel Landwerlin 2013-04-22 15:41:30 UTC 
Pushed to ALL THE BRANCHES!
Comment 8 Ondrej Holy 2013-04-26 13:48:38 UTC 
*** Bug 698130 has been marked as a duplicate of this bug. ***