GNOME Bugzilla – Bug 698259
0.10.8 - 'implicit declaration of functions'
Last modified: 2013-04-29 12:02:33 UTC
Created attachment 241796 [details] [review] Add the missing includes to application.c Building 0.10.8 results in two implicit declaration errors while building: 1) [ 9s] application.c: In function 'startup': [ 9s] application.c:268:2: warning: implicit declaration of function 'almanah_get_css_path' [-Wimplicit-function-declaration] [ 9s] application.c:268:2: warning: passing argument 1 of 'g_build_filename' makes pointer from integer without a cast [enabled by default] [ 9s] In file included from /usr/include/glib-2.0/glib.h:50:0, [ 9s] from application.c:21: [ 9s] /usr/include/glib-2.0/glib/gfileutils.h:132:10: note: expected 'const gchar *' but argument is of type 'int' [ 9s] application.c: In function 'almanah_application_init_actions': [ 9s] application.c:398:2: warning: implicit declaration of function 'almanah_get_interface_app_menu_filename' [-Wimplicit-function-declaration] [ 9s] application.c:398:36: warning: initialization makes pointer from integer without a cast [enabled by default] [ 9s] CC almanah-storage-manager.o [ 9s] CC almanah-search-dialog.o application.c does not #include interface.h (see patch) 2) [ 12s] CC events/almanah-calendar-appointment.o [ 12s] event-factories/calendar-sources.c: In function 'get_ecal_from_source': [ 12s] event-factories/calendar-sources.c:276:3: warning: implicit declaration of function 'e_cal_client_new' [-Wimplicit-function-declaration] [ 12s] event-factories/calendar-sources.c:276:10: warning: assignment makes pointer from integer without a cast [enabled by default] => e_cal_client_new() has been deprecated (I worked around with CFLAGS="-UE_CAL_DISABLE_DEPRECATED"
Review of attachment 241796 [details] [review]: Good.
(In reply to comment #0) > Created an attachment (id=241796) [details] [review] > Add the missing includes to application.c > > Building 0.10.8 results in two implicit declaration errors while building: > > 2) > [ 12s] CC events/almanah-calendar-appointment.o > [ 12s] event-factories/calendar-sources.c: In function > 'get_ecal_from_source': > [ 12s] event-factories/calendar-sources.c:276:3: warning: implicit > declaration of function 'e_cal_client_new' [-Wimplicit-function-declaration] > [ 12s] event-factories/calendar-sources.c:276:10: warning: assignment makes > pointer from integer without a cast [enabled by default] > > => e_cal_client_new() has been deprecated (I worked around with > CFLAGS="-UE_CAL_DISABLE_DEPRECATED" At the moment, Almanah 0.10.8 only requires libecal >= 3.5.91 and e_cal_client_new has been deprecated since 3.8. I'll create another bug to resolve the warning and update the required version of EDS to 3.8 pointing Almanah 0.11 release. Thanks for your patch and feedback.