After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698053 - Use GdMainView
Use GdMainView
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on: 698055
Blocks:
 
 
Reported: 2013-04-15 11:30 UTC by Alexander Larsson
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ContentView: Switch to GdMainView (10.32 KB, patch)
2013-04-15 11:36 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2013-04-15 11:30:21 UTC 
We should use GdMainView rather than GdMainIconView directly, this lets us remove code and get the new range selection stuff from GdMainView.
Comment 1 Alexander Larsson 2013-04-15 11:35:47 UTC 
This depends on the libgd patch in  bug 698055.
Comment 2 Alexander Larsson 2013-04-15 11:36:20 UTC 
Created attachment 241558 [details] [review]
ContentView: Switch to GdMainView

Instead of using GdMainIconView directly we use GdMain, which lets
us remove some event handling code and get the new range selection
behaviour.
Comment 3 Alexander Larsson 2013-04-15 11:37:03 UTC 
Also, we don't get the new range selection mode unless we also bump libgd to latest version.
Comment 4 Zeeshan Ali 2013-04-15 15:36:00 UTC 
Review of attachment 241558 [details] [review]:

Looks good but please also update libgd version (preferably in a separate patch) before merging this.

One issue I saw was that 'Done' button in collection view now appears as 'D_one'. Its probably just my env messed-up but please do ensure that before merging.

::: src/collection-view.vala
@@ +306,3 @@
         model_filter.set_visible_func (model_visible);
 
+        // The normal construction has some issues

Filing a bug on that and adding a ref here would give you bonus points. :)
Comment 5 Zeeshan Ali 2013-04-15 17:05:11 UTC 
Attachment 241558 [details] pushed as 6894bcf - ContentView: Switch to GdMainView
Comment 6 Alexander Larsson 2013-04-15 18:26:40 UTC 
Constructor bug reference:
https://bugzilla.gnome.org/show_bug.cgi?id=698056