After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698046 - add -ldl to libgstvaapi-glx-1.0.so
add -ldl to libgstvaapi-glx-1.0.so
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-04-15 09:13 UTC by Víctor Manuel Jáquez Leal
Modified: 2013-04-15 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
link libgstvaapi-glx-1.0.so against libdl (1.58 KB, patch)
2013-04-15 09:26 UTC, Víctor Manuel Jáquez Leal 		none Details | Review
link libgstvaapi-glx-1.0.so against libdl (1.59 KB, patch)
2013-04-15 10:23 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2013-04-15 09:13:52 UTC 
Got this error when compiling in Fedora17 for 32 bits


../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference to 'dlerr
or'
../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference to 'dlsym
'
collect2: error: ld returned 1 exit status
make[2]: *** [test-display] Error 1
make[2]: *** Waiting for unfinished jobs....
../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference to 'dlerr
or'
../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference to 'dlsym
'
collect2: error: ld returned 1 exit status
Comment 1 Víctor Manuel Jáquez Leal 2013-04-15 09:26:18 UTC 
Created attachment 241551 [details] [review]
link libgstvaapi-glx-1.0.so against libdl
Comment 2 Philippe Normand 2013-04-15 09:47:06 UTC 
Review of attachment 241551 [details] [review]:

::: gst-libs/gst/vaapi/Makefile.am
@@ -328,2 +328,3 @@
 	$(LIBVA_GLX_LIBS)			\
 	libgstvaapi-x11-$(GST_API_VERSION).la	\
+	$(DLOPEN_LIBS)

Missing ending backslash perhaps?
Comment 3 Víctor Manuel Jáquez Leal 2013-04-15 10:20:33 UTC 
(In reply to comment #2)
> Review of attachment 241551 [details] [review]:
> 
> ::: gst-libs/gst/vaapi/Makefile.am
> @@ -328,2 +328,3 @@
>      $(LIBVA_GLX_LIBS)            \
>      libgstvaapi-x11-$(GST_API_VERSION).la    \
> +    $(DLOPEN_LIBS)
> 
> Missing ending backslash perhaps?

yup...
Comment 4 Víctor Manuel Jáquez Leal 2013-04-15 10:23:05 UTC 
Created attachment 241554 [details] [review]
link libgstvaapi-glx-1.0.so against libdl
Comment 5 Gwenole Beauchesne 2013-04-15 12:05:41 UTC 
Hi,

(In reply to comment #0)
> Got this error when compiling in Fedora17 for 32 bits
> 
> 
> ../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference
> to 'dlerr
> or'
> ../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference
> to 'dlsym
> '
> collect2: error: ld returned 1 exit status
> make[2]: *** [test-display] Error 1
> make[2]: *** Waiting for unfinished jobs....
> ../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference
> to 'dlerr
> or'
> ../gst-libs/gst/vaapi/.libs/libgstvaapi-glx-1.0.so: error: undefined reference
> to 'dlsym
> '
> collect2: error: ld returned 1 exit status

Since libgstvaapi*.so is not directly using dlopen() et al. then I believe the issue may reside in one of its immediate dependency instead. Though, I don't know which one.
Comment 6 Víctor Manuel Jáquez Leal 2013-04-15 12:50:24 UTC 
(In reply to comment #5)
> 
> Since libgstvaapi*.so is not directly using dlopen() et al. then I believe the
> issue may reside in one of its immediate dependency instead. Though, I don't
> know which one.

but... I'm confused...

$ git grep dlsym
gst-libs/gst/vaapi/gstvaapiutils_glx.c:    *(void **)(&get_proc_func) = dlsym(RTLD_DEFAULT, "glXGetProcAddress");
gst-libs/gst/vaapi/gstvaapiutils_glx.c:    *(void **)(&get_proc_func) = dlsym(RTLD_DEFAULT, "glXGetProcAddressARB");
Comment 7 Gwenole Beauchesne 2013-04-15 12:55:57 UTC 
Argh, you are right. :)
Comment 8 Gwenole Beauchesne 2013-04-15 13:11:44 UTC 
Review of attachment 241554 [details] [review]:

I have pushed the patch minus the DEFINES, which are not used.