After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 698022 - unused code in gxps-archive
unused code in gxps-archive
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-14 22:28 UTC by Juanjo Marín
Modified: 2013-04-17 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.41 KB, patch)
2013-04-14 22:34 UTC, Juanjo Marín 		accepted-commit_now Details | Review

Description Juanjo Marín 2013-04-14 22:28:10 UTC 
AFAIK, _GXPSArchiveEntry and GXPSArchiveEntry is not used anywhere and there is a result variable gxps_archive_input_stream_next_piece that is not used neither.
Comment 1 Juanjo Marín 2013-04-14 22:34:45 UTC 
Created attachment 241533 [details] [review]
Proposed patch
Comment 2 Carlos Garcia Campos 2013-04-15 17:09:52 UTC 
Review of attachment 241533 [details] [review]:

Right, GXPSArchiveEntry has never been used actually, I guess it's a leftover of a previous patch that I never removed. Please push it in two different commits, one for the ArchiveEntry and another one for the unused local variable. And include the URL of the bug in the commit message in both cases in the extended message part instead of Fixes bgo #698022: in the first line. Thanks!
Comment 3 Juanjo Marín 2013-04-17 22:14:52 UTC 
Pushed in master
	d916eddcc321f6072a64e8a7618bf0f1d4e51d04
	adbfe0eae9396769d64e050651754ac2a08bd457

done !