After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697961 - Use gresources for .ui files
Use gresources for .ui files
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-13 17:49 UTC by Paolo Borelli
Modified: 2013-04-14 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gresources for .ui files (5.51 KB, patch)
2013-04-13 17:49 UTC, Paolo Borelli 		committed Details | Review
patch (446.56 KB, patch)
2013-04-14 07:41 UTC, Paolo Borelli 		committed Details | Review

Description Paolo Borelli 2013-04-13 17:49:17 UTC 
Note this depends on bug 697960 for a fixed vala vapi
Comment 1 Paolo Borelli 2013-04-13 17:49:20 UTC 
Created attachment 241463 [details] [review]
Use gresources for .ui files
Comment 2 Robert Ancell 2013-04-13 22:45:25 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Robert Ancell 2013-04-13 22:46:07 UTC 
Review of attachment 241463 [details] [review]:

Thanks Paolo! I committed this with a workaround for the gtk_builder_add_objects_from_resource fix so we don't have to depend on a bleeding edge vala.
Comment 4 Paolo Borelli 2013-04-14 06:58:38 UTC 
These days glade easily allows to right click on a container (e.g. GtkTable) and use it at toplevel. If we do that we can cleanup the ui files and then simply use builder.add_from_resource which does not have the vala issue... If you agree I can make a patch
Comment 5 Paolo Borelli 2013-04-14 07:41:23 UTC 
Created attachment 241484 [details] [review]
patch

here is the patch as per the comment above. The changes to the ui files just consist of removing GtkWindow and unindenting (plus removing the obsolete gtk2 line at the top)
Comment 6 Robert Ancell 2013-04-14 21:25:20 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 7 Robert Ancell 2013-04-14 21:25:31 UTC 
Review of attachment 241484 [details] [review]:

Yay, much simpler :)