After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697942 - abicheck.sh fails on mips
abicheck.sh fails on mips
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.36.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-04-13 10:03 UTC by Emilio Pozuelo Monfort
Modified: 2013-04-16 16:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
allow _ftext in the exported symbols (1.02 KB, patch)
2013-04-13 10:04 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Emilio Pozuelo Monfort 2013-04-13 10:03:16 UTC 
On mips _ftext is leaked into the binaries, thus abicheck.sh. See also [1]

[1] http://cgit.freedesktop.org/harfbuzz/commit/?id=6c1e8b614cfd6ed016fba6bf20af1e422e79eb71
Comment 1 Emilio Pozuelo Monfort 2013-04-13 10:04:11 UTC 
Created attachment 241438 [details] [review]
allow _ftext in the exported symbols
Comment 2 Emilio Pozuelo Monfort 2013-04-13 10:05:28 UTC 
Would be good to have this on glib-2-36 too.
Comment 3 Matthias Clasen 2013-04-13 15:54:00 UTC 
isn't that a toolchain bug that should be fixed there ?
Comment 4 Allison Karlitskaya (desrt) 2013-04-16 11:58:41 UTC 
Review of attachment 241438 [details] [review]:

I'm fine with this.  Even if it's a mips toolchain issue, that's not our problem (and this script is only to detect things that are our problem).
Comment 5 Emilio Pozuelo Monfort 2013-04-16 13:47:47 UTC 
Comment on attachment 241438 [details] [review]
allow _ftext in the exported symbols

Thanks, pushed to master.

As for fixing this in mips, I don't think that would be even possible. _finit seems to be there by design to support knowing the size of some stuff, probably like _init & _fini.