After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697686 - rtsp-client: send out teardown signal before tearing down
rtsp-client: send out teardown signal before tearing down
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-10 06:16 UTC by David Svensson Fors
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Send out teardown signal before tearing down (1.29 KB, patch)
2013-04-10 06:16 UTC, David Svensson Fors 		none Details | Review

Description David Svensson Fors 2013-04-10 06:16:55 UTC 
Created attachment 241115 [details] [review]
Send out teardown signal before tearing down

The attached patch contains a suggested change in rtsp-client.c: to emit the "teardown-request" signal *before* tearing down the streams, instead of after. The advantage is that in the signal handler you get direct access to information about what streams are about to get torn down (in the GstRTSPClientState).

The feature I'm working on is to log setups and teardowns for each stream. Without this patch, I have to save information about the streams separately, so it is available when it is time to log teardowns.
Comment 1 Wim Taymans 2013-04-15 10:39:09 UTC 
commit bba7c4042d1d0384affa0f94ae0cff7c1a2c9908
Author: David Svensson Fors <davidsf@axis.com>
Date:   Mon Apr 15 12:21:54 2013 +0200

    client: send out teardown signal before tearing down
    
    The advantage is that in the signal handler you get direct access to
    information about what streams are about to get torn down (in the
    GstRTSPClientState).
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=697686