After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697610 - gstpad test fails due to unclean buffers list
gstpad test fails due to unclean buffers list
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-09 07:18 UTC by LRN
Modified: 2013-04-09 08:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Clear the list at the beginning of each test (2.02 KB, patch)
2013-04-09 07:18 UTC, LRN 		committed Details | Review

Description LRN 2013-04-09 07:18:02 UTC 
"buffers" is the global list in libgstcheck.
gstpad testsuite checks the length of that list to see how many buffers came through the pad.
Several tests are performed (with new pads every time), but buffers list is never cleared.
test_sticky_caps_unlinked causes one buffer to be pushed into the list, and subsequent test (test_sticky_caps_unlinked_incompatible) fails because of that.
Comment 1 LRN 2013-04-09 07:18:41 UTC 
Created attachment 241012 [details] [review]
Clear the list at the beginning of each test
Comment 2 Tim-Philipp Müller 2013-04-09 08:59:03 UTC 
Pushed with changes, thanks for the patch!

 commit 54aaba5f2163d57d2f6b72e10e45a55c9626d6c1
 Author: Руслан Ижбулатов <lrn1986@gmail.com>
 Date:   Tue Apr 9 09:22:39 2013 +0400

    tests: fix GstPad test on windows and in CK_FORK=no mode
    
    Need to clear buffer lists at the end of each test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=697610

The drop_buffers should really be done at the end of the test as part of the test clean-up.