After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697303 - osxvideosink: compiler warning: implicit declaration of function 'pthread_self'
osxvideosink: compiler warning: implicit declaration of function 'pthread_self'
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Mac OS
: Normal normal
: 1.0.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-05 01:46 UTC by Todd Agulnick
Modified: 2013-04-05 08:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (428 bytes, patch)
2013-04-05 01:47 UTC, Todd Agulnick 		committed Details | Review

Description Todd Agulnick 2013-04-05 01:46:24 UTC 
Attempting to build against b79f667ef4766b3f22f698eb39a7f4339ff880f2 I get the following error:

osxvideosink.m: In function '-[GstOSXVideoSinkObject nsAppThread]':
osxvideosink.m:919: warning: implicit declaration of function 'pthread_self'
osxvideosink.m:919: warning: nested extern declaration of 'pthread_self'
osxvideosink.m:919: warning: assignment makes pointer from integer without a cast

The attached patch includes pthread.h to fix the problem.
Comment 1 Todd Agulnick 2013-04-05 01:47:15 UTC 
Created attachment 240682 [details] [review]
proposed patch
Comment 2 Tim-Philipp Müller 2013-04-05 08:36:57 UTC 
Thanks for the patch, pushed:

 commit a30476497fe8f1a4f5ba69c98b921c249922e6bf
 Author: Todd Agulnick <todd@agulnick.com>
 Date:   Fri Apr 5 09:34:23 2013 +0100

    osxvideo: include pthread.h to fix compiler warning
    
    https://bugzilla.gnome.org/show_bug.cgi?id=697303

Would be great if you could create patches in "git format-patch" format in future, that makes it easier for us too apply :)