After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697289 - gvfs readahead is overly aggressive
gvfs readahead is overly aggressive
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: daemon
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-04-04 17:48 UTC by Alexander Larsson
Modified: 2013-04-05 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix readahead behaviour (1.91 KB, patch)
2013-04-05 12:08 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2013-04-04 17:48:27 UTC 
Right now whenever you do a read on a GVfsReadChannel we start a readahead operation whenever a read is done, even if the last read was a readahead operation. This means that if you just keep a channel open without reading we will be sending a lot of data down the pipe.

We need some way to synchronize this so that unless the reader side actually reads some of the data we need to stop reading ahead.
Comment 1 Bastien Nocera 2013-04-04 21:46:04 UTC 
See also bug 697298 for the more specific GStreamer performance problem.
Comment 2 Alexander Larsson 2013-04-05 12:08:41 UTC 
Created attachment 240723 [details] [review]
Fix readahead behaviour

We were constantly adding extra readahead operations that were not really
needed. A single readahead is necessary to get the read operations
pipelined (see comment). Also, avoid readahead for the first read
to handle random access i/o better.
Comment 3 Alexander Larsson 2013-04-05 12:44:37 UTC 
Attachment 240723 [details] pushed as 4efd634 - Fix readahead behaviour