After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697283 - mpegdemux: accept ID_PRIVATE_STREAM_1 to avoid loosing sync
mpegdemux: accept ID_PRIVATE_STREAM_1 to avoid loosing sync
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: 1.0.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-04 16:40 UTC by Alban Browaeys
Modified: 2013-07-05 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpegdemux: accept ID_PRIVATE_STREAM_1 to avoid loosing sync (999 bytes, patch)
2013-04-04 16:40 UTC, Alban Browaeys 		committed Details | Review

Description Alban Browaeys 2013-04-04 16:40:08 UTC 
Created attachment 240638 [details] [review]
mpegdemux: accept  ID_PRIVATE_STREAM_1 to avoid loosing sync

Current fallback to lost_sync seems to impede a delay to restore
    sync. Let the parser parse and skip the private stream.
    Here it contains the digital camera brand (in 2010 bytes)
    and is repeated twice.
Comment 1 Tim-Philipp Müller 2013-04-05 08:57:01 UTC 
Looks fine to me, but could you make a short sample file available by any chance?
Comment 3 Sebastian Dröge (slomo) 2013-06-07 10:59:25 UTC 
commit 44b1bc608159226750f2d61817b89874304cc484
Author: Alban Browaeys <prahal@yahoo.com>
Date:   Thu Apr 4 18:22:52 2013 +0200

    mpegdemux: accept ID_PRIVATE_STREAM_1 to avoid loosing sync
    
    Current fallback to lost_sync seems to impede a delay to restore
    sync. Let the parser parse and skip the private stream.
    Here it contains the digital camera brand (in 2010 bytes)
    and is repeated twice.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=697283
Comment 4 Tim-Philipp Müller 2013-07-05 23:39:46 UTC 
Also picked into 1.0.